proposed fix for RunningMeanStd overflow#1954
Open
spiglerg wants to merge 4 commits intoDLR-RM:masterfrom
Open
proposed fix for RunningMeanStd overflow#1954spiglerg wants to merge 4 commits intoDLR-RM:masterfrom
spiglerg wants to merge 4 commits intoDLR-RM:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected to Issue #1953
Description
RunningMeanStd is made robust to overflows with two modifications:
Motivation and Context
Issue [Bug]: RunningMeanStd overflowing #1953
Closes [Bug]: RunningMeanStd overflowing #1953
I have raised an issue to propose this change (required for new features and bug fixes)
Types of changes
Checklist
make format(required)make check-codestyleandmake lint(required)make pytestandmake typeboth pass. (required)make doc(required)