Conversation
SyntheticBird45
force-pushed
the
onion_addr_test_fix
branch
from
52b19fd to
803a0c6
Compare
- Added two new tests `parse_random_valid_onion_address` and `parse_random_valid_onion_address_w_port`. - Fixed the two `*invalid_onion_address*` tests. The proptest syntax was invalid and we were trying to create a correct syntax for a test of invalid inputs. I don't know who is the author but this is quite stupid. They should be ashamed of themselves. Truly. Sincerely. Honestly. Frankly. Really? Git blame is left as an exercise for the reader.
SyntheticBird45
force-pushed
the
onion_addr_test_fix
branch
from
803a0c6 to
fabef8d
Compare
Boog900
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
parse_random_valid_onion_addressandparse_random_valid_onion_address_w_port.*invalid_onion_address*tests.Why
We were trying to make a correct syntax for a test that was meant to invalidate bad syntax. By accident the proptest string regex was not written correctly, resulting in broken onion addresses and therefore the tests succeeding.
I'm confused on how this situation happened in the first place but it is what it is.