cuprated: broadcast block before notifying txpool#597
Open
redsh4de wants to merge 1 commit intoCuprate:mainfrom
Open
cuprated: broadcast block before notifying txpool#597redsh4de wants to merge 1 commit intoCuprate:mainfrom
redsh4de wants to merge 1 commit intoCuprate:mainfrom
Conversation
redsh4de
force-pushed
the
feat/broadcast-before-txpool
branch
from
8f6e6b3 to
f652eea
Compare
redsh4de
force-pushed
the
feat/broadcast-before-txpool
branch
from
f652eea to
9af98c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #541
Why
Faster block propagation
Where
cuprated
How
Move the
block_blobextraction andbroadcast_blockcall insideadd_valid_block_to_main_chain, between the DB write and the txpool notification. Add aBlockSourceparameter naming each of the three call paths (Incoming, BatchSync, Reorg) - onlyIncomingtriggers the broadcast.