Sending and receiving messages#11
Open
felixoppongwillborg wants to merge 20 commits intoCraftAcademy:masterfrom
Open
Sending and receiving messages#11felixoppongwillborg wants to merge 20 commits intoCraftAcademy:masterfrom
felixoppongwillborg wants to merge 20 commits intoCraftAcademy:masterfrom
Conversation
…p now loads on server
…created a db migartion for add_missing_indices.mailboxer_engine
…nd the button functions which pass
…user_session_path then wrote test to locate Email to make sure i was in the right path second test was for filling in email, password and then clickon log in button
…ick on inbox and then compose message
…receive message. Rewrote test for sending and receiving messages all test pass
emtalen
reviewed
Jun 29, 2020
emtalen
left a comment
emtalen
left a comment
There was a problem hiding this comment.
You are not testing that the recipient actually receives the message, only that it is sent from the sender. Which is totally fine, but then you should change the description of the PR
| end | ||
| end | ||
|
|
||
|
|
| click_on 'Log in' | ||
| expect(page).to have_content 'Invalid Email or password.' | ||
| end | ||
| end |
There was a problem hiding this comment.
Please be consistent with the indentation, use 2 spaces and not 4
| expect(page).to have_content "Hej test" | ||
| end | ||
| end | ||
| end No newline at end of file |
There was a problem hiding this comment.
Please be consistent with the indentation, use 2 spaces and not 4
| end | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Remove this file if you are not using it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
][PT board URL( https://www.pivotaltracker.com/story/show/173511460 )
User Story
Changes proposed in this pull request:
What I have learned working on this feature: