Skip to content

Skip empty links in breadcrumbs#1789

Merged
cifarquhar merged 1 commit intomainfrom
skip-empty-breadcrumbs
Mar 20, 2026
Merged

Skip empty links in breadcrumbs#1789
cifarquhar merged 1 commit intomainfrom
skip-empty-breadcrumbs

Conversation

@illicitonion
Copy link
Member

If a _index.md file has build.render = "never" set, it ends up as an ancestor but without a link. This means we render a link with the title of the page, but with a blank link, which makes a link to the current page. This is never useful.

e.g. on https://piscine.codeyourfuture.io/sprints/1/day-plan/ there's a "Piscine" link that has an empty href (so points at the current page) which shouldn't be there. This is because
org-cyf-piscine/content/sprints/_index.md sets
build.render = "never" because it's a single-module course, so the extra level of nesting isn't so useful.

If a `_index.md` file has `build.render = "never"` set, it ends up as an
ancestor but without a link. This means we render a link with the title
of the page, but with a blank link, which makes a link to the current
page. This is never useful.

e.g. on https://piscine.codeyourfuture.io/sprints/1/day-plan/ there's a
"Piscine" link that has an empty `href` (so points at the current page)
which shouldn't be there. This is because
`org-cyf-piscine/content/sprints/_index.md` sets
`build.render = "never"` because it's a single-module course, so the
extra level of nesting isn't so useful.
@netlify
Copy link

netlify bot commented Mar 17, 2026

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit f26598e
🔍 Latest deploy log https://app.netlify.com/projects/cyf-curriculum/deploys/69b99db4c49696000859bf7d
😎 Deploy Preview https://deploy-preview-1789--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 17, 2026

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit f26598e
🔍 Latest deploy log https://app.netlify.com/projects/cyf-launch/deploys/69b99db489e4980008cf5f2c
😎 Deploy Preview https://deploy-preview-1789--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 17, 2026

Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit f26598e
🔍 Latest deploy log https://app.netlify.com/projects/cyf-common/deploys/69b99db43848020008a32c08
😎 Deploy Preview https://deploy-preview-1789--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 17, 2026

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit f26598e
🔍 Latest deploy log https://app.netlify.com/projects/cyf-programming/deploys/69b99db4745e480008889da0
😎 Deploy Preview https://deploy-preview-1789--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 15 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 17, 2026

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit f26598e
🔍 Latest deploy log https://app.netlify.com/projects/cyf-sdc/deploys/69b99db456a1b5000845fe42
😎 Deploy Preview https://deploy-preview-1789--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 17, 2026

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit f26598e
🔍 Latest deploy log https://app.netlify.com/projects/cyf-tracks/deploys/69b99db456a1b5000845fe47
😎 Deploy Preview https://deploy-preview-1789--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 17, 2026

Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit f26598e
🔍 Latest deploy log https://app.netlify.com/projects/cyf-itd/deploys/69b99db456a1b5000845fe4b
😎 Deploy Preview https://deploy-preview-1789--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 17, 2026

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit f26598e
🔍 Latest deploy log https://app.netlify.com/projects/cyf-piscine/deploys/69b99db4745e480008889da5
😎 Deploy Preview https://deploy-preview-1789--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 12 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@cifarquhar cifarquhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 👀 In review in Curriculum Planning Mar 20, 2026
@cifarquhar cifarquhar merged commit a6b6778 into main Mar 20, 2026
35 checks passed
@cifarquhar cifarquhar deleted the skip-empty-breadcrumbs branch March 20, 2026 14:33
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Curriculum Planning Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants