Open
Conversation
If a `_index.md` file has `build.render = "never"` set, it ends up as an ancestor but without a link. This means we render a link with the title of the page, but with a blank link, which makes a link to the current page. This is never useful. e.g. on https://piscine.codeyourfuture.io/sprints/1/day-plan/ there's a "Piscine" link that has an empty `href` (so points at the current page) which shouldn't be there. This is because `org-cyf-piscine/content/sprints/_index.md` sets `build.render = "never"` because it's a single-module course, so the extra level of nesting isn't so useful.
✅ Deploy Preview for cyf-curriculum ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-launch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-common ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-sdc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-tracks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-itd ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-piscine ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a
_index.mdfile hasbuild.render = "never"set, it ends up as an ancestor but without a link. This means we render a link with the title of the page, but with a blank link, which makes a link to the current page. This is never useful.e.g. on https://piscine.codeyourfuture.io/sprints/1/day-plan/ there's a "Piscine" link that has an empty
href(so points at the current page) which shouldn't be there. This is becauseorg-cyf-piscine/content/sprints/_index.mdsetsbuild.render = "never"because it's a single-module course, so the extra level of nesting isn't so useful.