Skip to content

Move protected_keys list inside want_int loop #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtarking merged 1 commit into from
Mar 12, 2026
Merged

Move protected_keys list inside want_int loop #649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions plugins/modules/dcnm_interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4352,9 +4352,6 @@ def dcnm_intf_replace_pc_members(self, want, have):
for key in self.pol_pc_member_types[self.dcnm_version].keys():
member_policy_names.append(self.pol_pc_member_types[self.dcnm_version][key])

# List of keys in nvPairs to protect
protected_keys = ["PO_ID", "PC_MODE", "INTF_NAME", "ALLOWED_VLANS", "DESC", "ADMIN_STATE", "CONF", "PRIMARY_INTF"]

for have_int in have:
if have_int["policy"] in member_policy_names:
# We have a port-channel member interface. Find the corresponding port-channel
Expand All @@ -4363,6 +4360,8 @@ def dcnm_intf_replace_pc_members(self, want, have):
have_pc_serial = have_int["interfaces"][0]["serialNumber"]

for want_int in want:
# List of keys in nvPairs to protect
protected_keys = ["PO_ID", "PC_MODE", "INTF_NAME", "ALLOWED_VLANS", "DESC", "ADMIN_STATE", "CONF", "PRIMARY_INTF"]
match_int = find_dict_in_list_by_key_value(search=want_int['interfaces'], key='ifName', value=have_pc_name)
if match_int and match_int['serialNumber'] == have_pc_serial:
msg = "\nHave Interface Info: "
Expand Down
Loading