Skip to content

fix: skip unnecessary network reset during emulation restore #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhananjay6561 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: skip unnecessary network reset during emulation restore #1891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d92ffd
Skip unnecessary network reset during emulation restore
dhananjay6561 Apr 17, 2026
64a960b
Merge branch 'main' into fix/lighthouse-network-timeout-restore
dhananjay6561 Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/McpContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,9 @@ export class McpContext implements Context {

async restoreEmulation(page: McpPage) {
const currentSetting = page.emulationSettings;
await this.emulate(currentSetting, page.pptrPage);
await this.emulate(currentSetting, page.pptrPage, {
skipNetworkReset: !currentSetting.networkConditions,
});
}

async emulate(
Expand All @@ -297,13 +299,18 @@ export class McpContext implements Context {
viewport?: Viewport;
},
targetPage?: Page,
internalOptions: {
skipNetworkReset?: boolean;
} = {},
): Promise<void> {
const page = targetPage ?? this.getSelectedPptrPage();
const mcpPage = this.#getMcpPage(page);
const newSettings: EmulationSettings = {...mcpPage.emulationSettings};

if (!options.networkConditions) {
await page.emulateNetworkConditions(null);
if (!internalOptions.skipNetworkReset) {
await page.emulateNetworkConditions(null);
}
delete newSettings.networkConditions;
} else if (options.networkConditions === 'Offline') {
await page.emulateNetworkConditions({
Expand Down
14 changes: 14 additions & 0 deletions tests/McpContext.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,20 @@ describe('McpContext', () => {
});
});

it('does not reset network during restore when no network emulation exists', async () => {
await withMcpContext(async (_response, context) => {
const page = context.getSelectedMcpPage();
const emulateNetworkConditionsSpy = sinon.spy(
page.pptrPage,
'emulateNetworkConditions',
);

await context.restoreEmulation(page);

sinon.assert.notCalled(emulateNetworkConditionsSpy);
});
});

it('should call waitForEventsAfterAction with correct multipliers', async () => {
await withMcpContext(async (_response, context) => {
const page = await context.newPage();
Expand Down