Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-crate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
run: cargo ws publish --publish-as-is --dry-run

- name: Upload crate artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: crate
path: ./target/package/*-*.crate
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
wasm-pack pack

- name: Upload NPM pkg artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: npm-pkg
path: ./wasm/pkg/*-*.tgz
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-riscv64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
'

- name: Upload artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: packages-${{ matrix.os }}-${{ matrix.python.major-dot-minor }}
path: ./target/wheels
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ jobs:
rm -rf "${TMP_DEST}"

- name: Upload artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mismatched upload-artifact v7 with download-artifact v4

High Severity

actions/upload-artifact is bumped to v7 but the corresponding actions/download-artifact steps in the same workflows remain at v4. In build-wheels.yml (line 481) and build-riscv64.yml (line 118), download-artifact@v4 is used to download artifacts uploaded by upload-artifact@v7. While the default archive mode may still be compatible, mixing major versions across upload/download pairs is not recommended by GitHub and risks download failures during release publishing, which would block PyPI uploads.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2379606. Configure here.

with:
name: packages-${{ matrix.os.name }}-${{ matrix.python.major-dot-minor }}-${{ matrix.arch.name }}
path: ./target/wheels/
Expand Down Expand Up @@ -274,7 +274,7 @@ jobs:
rm -rf "$dirname"

- name: Upload artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: packages-sdist-${{ matrix.os.name }}-${{ matrix.python.major-dot-minor }}-${{ matrix.arch.name }}
path: ./target/wheels/
Expand Down
Loading