Skip to content

Bump actions/upload-artifact from 4 to 7 #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

Bump actions/upload-artifact from 4 to 7 #1382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-crate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
run: cargo ws publish --publish-as-is --dry-run

- name: Upload crate artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: crate
path: ./target/package/*-*.crate
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
wasm-pack pack

- name: Upload NPM pkg artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: npm-pkg
path: ./wasm/pkg/*-*.tgz
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-riscv64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
'

- name: Upload artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
Copy link
Copy Markdown

@cursor cursor Bot Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upload/download artifact version mismatch may break downloads

Medium Severity

actions/upload-artifact is bumped to v7 but actions/download-artifact remains at v4 in both build-riscv64.yml (line 118) and build-wheels.yml (line 479). These upload/download action pairs are designed to be used at matching major versions. The upload jobs produce artifacts that later jobs in the same workflow attempt to download—a version mismatch risks download failures if the v7 upload uses API features that v4 download doesn't understand. download-artifact v7 exists and needs to be bumped in tandem.

Additional Locations (1)

Fix in Cursor Fix in Web

with:
name: packages-${{ matrix.os }}-${{ matrix.python.major-dot-minor }}
path: ./target/wheels
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ jobs:
rm -rf "${TMP_DEST}"

- name: Upload artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: packages-${{ matrix.os.name }}-${{ matrix.python.major-dot-minor }}-${{ matrix.arch.name }}
path: ./target/wheels/
Expand Down Expand Up @@ -274,7 +274,7 @@ jobs:
rm -rf "$dirname"

- name: Upload artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: packages-sdist-${{ matrix.os.name }}-${{ matrix.python.major-dot-minor }}-${{ matrix.arch.name }}
path: ./target/wheels/
Expand Down