Skip to content

vroom#1380

Open
wjblanke wants to merge 5 commits intomainfrom
avx512wjb
Open

vroom#1380
wjblanke wants to merge 5 commits intomainfrom
avx512wjb

Conversation

@wjblanke
Copy link
Copy Markdown

@wjblanke wjblanke commented Mar 5, 2026

DO NOT MERGE

with

cargo test -p blst --features vroom

without

cargo test -p blst

I changed the pairing related tests to loop 100 times to do kind of a benchmark.

On Ryzen 7 7800X3D under WSL Ubuntu I didn't see much difference. 16.4 seconds either way


Note

High Risk
Touches cryptography build/linking and pairing implementation selection, with a large new vendored blst surface and optional alternate native code path that can impact correctness and platform builds.

Overview
Introduces git submodules for vroom and blst-src and overrides crates.io blst via [patch.crates-io]/workspace deps to ensure the workspace links a single native blst implementation.

Adds a new local crates/blst crate (bindings + build script) that compiles blst-src, and when the vroom feature is enabled, stages a copy of the sources with pairing.c replaced by VROOM’s version; chia-bls exposes a vroom feature and documents the pairing backend behavior/clone requirements in README.md.

Written by Cursor Bugbot for commit 65ea962. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Experimental vroom feature enabled by default contradicts documentation
    • I made vroom opt-in by changing chia-bls default features to empty so the standard backend remains default unless explicitly enabled.

Create PR

Or push these changes by commenting:

@cursor push 37e9c05f7f
Preview (37e9c05f7f)
diff --git a/crates/chia-bls/Cargo.toml b/crates/chia-bls/Cargo.toml
--- a/crates/chia-bls/Cargo.toml
+++ b/crates/chia-bls/Cargo.toml
@@ -12,7 +12,7 @@
 workspace = true
 
 [features]
-default = ["vroom"]
+default = []
 py-bindings = ["dep:pyo3", "dep:chia_py_streamable_macro", "chia-traits/py-bindings"]
 arbitrary = ["dep:arbitrary"]
 serde = ["dep:serde", "dep:chia-serde"]
This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Comment thread crates/chia-bls/Cargo.toml Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread crates/blst/build.rs
@wjblanke wjblanke marked this pull request as draft March 5, 2026 17:45
@wjblanke wjblanke marked this pull request as ready for review March 5, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant