Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Experimental vroom feature enabled by default contradicts documentation
- I made
vroomopt-in by changingchia-blsdefault features to empty so the standard backend remains default unless explicitly enabled.
- I made
Or push these changes by commenting:
@cursor push 37e9c05f7f
Preview (37e9c05f7f)
diff --git a/crates/chia-bls/Cargo.toml b/crates/chia-bls/Cargo.toml
--- a/crates/chia-bls/Cargo.toml
+++ b/crates/chia-bls/Cargo.toml
@@ -12,7 +12,7 @@
workspace = true
[features]
-default = ["vroom"]
+default = []
py-bindings = ["dep:pyo3", "dep:chia_py_streamable_macro", "chia-traits/py-bindings"]
arbitrary = ["dep:arbitrary"]
serde = ["dep:serde", "dep:chia-serde"]There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

DO NOT MERGE
with
cargo test -p blst --features vroom
without
cargo test -p blst
I changed the pairing related tests to loop 100 times to do kind of a benchmark.
On Ryzen 7 7800X3D under WSL Ubuntu I didn't see much difference. 16.4 seconds either way
Note
High Risk
Touches cryptography build/linking and pairing implementation selection, with a large new vendored
blstsurface and optional alternate native code path that can impact correctness and platform builds.Overview
Introduces git submodules for
vroomandblst-srcand overrides crates.ioblstvia[patch.crates-io]/workspace deps to ensure the workspace links a single nativeblstimplementation.Adds a new local
crates/blstcrate (bindings + build script) that compilesblst-src, and when thevroomfeature is enabled, stages a copy of the sources withpairing.creplaced by VROOM’s version;chia-blsexposes avroomfeature and documents the pairing backend behavior/clone requirements inREADME.md.Written by Cursor Bugbot for commit 65ea962. This will update automatically on new commits. Configure here.