Refactor ErrorCode to include NodePtr and drop ValidationErr#1348
Open
cameroncooper wants to merge 1 commit intomainfrom
Open
Refactor ErrorCode to include NodePtr and drop ValidationErr#1348cameroncooper wants to merge 1 commit intomainfrom
cameroncooper wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| let code1 = u32::from(msg1); | ||
| let code2 = u32::from(msg2); | ||
| if code1 != code2 { | ||
| assert!(discrepancy_errors.contains(&code1) || discrepancy_errors.contains(&code2)); |
There was a problem hiding this comment.
Fuzz test drops node-data comparison weakening assertion
Low Severity
The old error comparison checked both error code equality AND node data equality (node_to_bytes). The new code only compares u32 error codes via u32::from, completely dropping the node-data check. If two runs fail with the same error type but at different CLVM nodes (indicating a meaningful behavioral difference), the fuzz test will no longer detect it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Medium Risk
Wide, cross-cutting change to error types and propagation across consensus-critical parsing/validation code; behavior should be equivalent but regressions could surface via mismatched error construction or lost node context.
Overview
Refactors validation errors to eliminate
ValidationErrand makeErrorCodecarry location context. A newerror_codemodule definesErrorCodevariants that embedNodePtr(orOption<NodePtr>) and provides CLVM list helpers (first/rest/next/atom/check_nil) plusu32mapping and EvalErr/io conversions.All consensus/mempool paths (condition parsing/validation, generator execution, spendbundle validation, additions/removals, message parsing, timelock checks, fingerprinting, sanitizers) are updated to return
Result<_, ErrorCode>and construct errors via the new variants/closures; tests and fuzz targets are adjusted to compare by numeric code or pattern-match variants.Error::Validationnow wrapsErrorCodedirectly (withFrom<ErrorCode>), andlib.rsexportserror_codeinstead ofvalidation_error.Written by Cursor Bugbot for commit 71f388e. This will update automatically on new commits. Configure here.