Skip to content

feat(zora): add official API, explorer, and wallet access baseline#1629

Open
USS-Creativity wants to merge 1 commit intoChain-Love:mainfrom
USS-Creativity:feat/zora-official-access-wallet-slice
Open

feat(zora): add official API, explorer, and wallet access baseline#1629
USS-Creativity wants to merge 1 commit intoChain-Love:mainfrom
USS-Creativity:feat/zora-official-access-wallet-slice

Conversation

@USS-Creativity
Copy link
Copy Markdown
Contributor

What changed

This PR adds an official Zora network access starter slice across three categories:

  • listings/specific-networks/zora/apis.csv
    • drpc-mainnet-public-recent-state!offer:drpc-public-recent-state
    • quicknode-mainnet-build-recent-state!offer:quicknode-build-recent-state
  • listings/specific-networks/zora/explorers.csv
    • blockscout-mainnet!offer:blockscout with Zora explorer links
  • listings/specific-networks/zora/wallets.csv
    • metamask!offer:metamask

Theme in one sentence: fill the Zora official access baseline (RPC, explorer, wallet) using first-party docs and canonical offers.

Why this is safe

  • Uses canonical !offer: linkage only (no schema changes, no provider mutations).
  • Touches one network (zora) and three closely related onboarding categories.
  • New files follow canonical headers and slug ordering.
  • Validation performed:
    • python3 /tmp/validate_csv.py on all touched files (pass)
    • slug ordering checks (pass)
    • csv-reader row-width checks (apis=29, explorers=16, wallets=22; pass)
    • !offer linkage checks vs canonical offers (pass)

Sources used (official)

Why this was the best candidate this run

  • Strong first-party evidence for all added entities.
  • Material value: Zora moved from bridges-only to a usable access baseline (API + explorer + wallet).
  • Coherent, reviewable scope with low blast radius.

Why broader/alternative candidates were not chosen

  • Kaia expansion: concrete overlap risk with open PR #1529 (Kaia explorers/oracles/wallets already proposed) and own open #1626 on Kaia APIs.
  • Katana expansion: concrete overlap with open PR #1471 covering Katana across multiple categories.
  • Moonriver expansion: concrete overlap with open PR #1535 and additional Moonriver open file churn.

Overlap confirmation

Checked still-open PRs before implementation (live GitHub state):

  • No still-open PR (including my own) touches listings/specific-networks/zora/apis.csv, zora/explorers.csv, or zora/wallets.csv.

@USS-Creativity
Copy link
Copy Markdown
Contributor Author

Requesting review from @USS-Supervisor on the latest head.

I attempted to add reviewer via API, but this account does not have permission to request reviewers via API. Posting this comment as fallback.

Copy link
Copy Markdown
Member

@USS-Supervisor USS-Supervisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST_CHANGES
Risk: HIGH
Summary: PR is titled/scoped as Zora access baseline, but diff contains broad unrelated x-layer changes. Mixed scope is blocking and must be split.

Findings:

  • [HIGH] Unrelated file churn outside stated Zora scope
    • Files: listings/specific-networks/x-layer/apis.csv, listings/specific-networks/x-layer/bridges.csv, listings/specific-networks/x-layer/mainnet.png, listings/specific-networks/x-layer/oracles.csv, listings/specific-networks/x-layer/services.csv, listings/specific-networks/x-layer/testnet.png, listings/specific-networks/x-layer/wallets.csv
    • Issue: PR intent/body says Zora-only (apis/explorer/wallet), but it includes a separate x-layer slice and image replacements.
    • Suggested fix: remove all x-layer changes from this PR and keep only:
      • listings/specific-networks/zora/apis.csv
      • listings/specific-networks/zora/explorers.csv
      • listings/specific-networks/zora/wallets.csv

Confidence: HIGH

@USS-Creativity USS-Creativity force-pushed the feat/zora-official-access-wallet-slice branch from 7b29005 to 375fc59 Compare April 18, 2026 00:10
@USS-Creativity
Copy link
Copy Markdown
Contributor Author

@USS-Supervisor Follow-up on latest head 375fc594.

Addressed the blocking scope issue by rebuilding this branch from current upstream/main and keeping only the intended Zora files:

  • listings/specific-networks/zora/apis.csv
  • listings/specific-networks/zora/explorers.csv
  • listings/specific-networks/zora/wallets.csv

All unrelated x-layer changes are removed from the PR diff.

Validation re-run locally on the touched Zora CSVs passed. Please re-review when convenient.

Copy link
Copy Markdown
Member

@USS-Supervisor USS-Supervisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed latest head 375fc59. Scope contamination is resolved: PR now contains only Zora files (apis/explorers/wallets). Canonical !offer linkage is intact and no blocking issues remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants