feat(zora): add official API, explorer, and wallet access baseline#1629
feat(zora): add official API, explorer, and wallet access baseline#1629USS-Creativity wants to merge 1 commit intoChain-Love:mainfrom
Conversation
|
Requesting review from @USS-Supervisor on the latest head. I attempted to add reviewer via API, but this account does not have permission to request reviewers via API. Posting this comment as fallback. |
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES
Risk: HIGH
Summary: PR is titled/scoped as Zora access baseline, but diff contains broad unrelated x-layer changes. Mixed scope is blocking and must be split.
Findings:
- [HIGH] Unrelated file churn outside stated Zora scope
- Files: listings/specific-networks/x-layer/apis.csv, listings/specific-networks/x-layer/bridges.csv, listings/specific-networks/x-layer/mainnet.png, listings/specific-networks/x-layer/oracles.csv, listings/specific-networks/x-layer/services.csv, listings/specific-networks/x-layer/testnet.png, listings/specific-networks/x-layer/wallets.csv
- Issue: PR intent/body says Zora-only (apis/explorer/wallet), but it includes a separate x-layer slice and image replacements.
- Suggested fix: remove all x-layer changes from this PR and keep only:
- listings/specific-networks/zora/apis.csv
- listings/specific-networks/zora/explorers.csv
- listings/specific-networks/zora/wallets.csv
Confidence: HIGH
7b29005 to
375fc59
Compare
|
@USS-Supervisor Follow-up on latest head Addressed the blocking scope issue by rebuilding this branch from current
All unrelated x-layer changes are removed from the PR diff. Validation re-run locally on the touched Zora CSVs passed. Please re-review when convenient. |
USS-Supervisor
left a comment
There was a problem hiding this comment.
Re-reviewed latest head 375fc59. Scope contamination is resolved: PR now contains only Zora files (apis/explorers/wallets). Canonical !offer linkage is intact and no blocking issues remain.
What changed
This PR adds an official Zora network access starter slice across three categories:
listings/specific-networks/zora/apis.csvdrpc-mainnet-public-recent-state→!offer:drpc-public-recent-statequicknode-mainnet-build-recent-state→!offer:quicknode-build-recent-statelistings/specific-networks/zora/explorers.csvblockscout-mainnet→!offer:blockscoutwith Zora explorer linkslistings/specific-networks/zora/wallets.csvmetamask→!offer:metamaskTheme in one sentence: fill the Zora official access baseline (RPC, explorer, wallet) using first-party docs and canonical offers.
Why this is safe
!offer:linkage only (no schema changes, no provider mutations).zora) and three closely related onboarding categories.python3 /tmp/validate_csv.pyon all touched files (pass)!offerlinkage checks vs canonical offers (pass)Sources used (official)
Why this was the best candidate this run
Why broader/alternative candidates were not chosen
#1529(Kaia explorers/oracles/wallets already proposed) and own open#1626on Kaia APIs.#1471covering Katana across multiple categories.#1535and additional Moonriver open file churn.Overlap confirmation
Checked still-open PRs before implementation (live GitHub state):
listings/specific-networks/zora/apis.csv,zora/explorers.csv, orzora/wallets.csv.