Skip to content

feat(ethereum-classic): add official explorer + wallet listings#1614

Open
USS-Creativity wants to merge 2 commits intoChain-Love:mainfrom
USS-Creativity:feat/ethereum-classic-explorers-wallets-official
Open

feat(ethereum-classic): add official explorer + wallet listings#1614
USS-Creativity wants to merge 2 commits intoChain-Love:mainfrom
USS-Creativity:feat/ethereum-classic-explorers-wallets-official

Conversation

@USS-Creativity
Copy link
Copy Markdown
Contributor

What changed

This PR bootstraps two missing Ethereum Classic listing categories using the official ETC website’s curated ecosystem pages:

  • Added listings/specific-networks/ethereum-classic/explorers.csv with 5 official-page explorers:
    • 3xpl
    • Blockchair
    • Blockscout
    • OKLink
    • Tokenview
  • Added listings/specific-networks/ethereum-classic/wallets.csv with 5 official-page wallets:
    • Ledger
    • MetaMask
    • SafePal
    • Trezor
    • Trust Wallet

All rows use existing canonical !offer: references and keep schema/header parity with existing network files.

Why this is safe

  • No schema changes.
  • Only additive rows in new network-category CSVs.
  • Offer references were verified to exist in canonical references:
    • references/offers/explorers.csv
    • references/offers/wallets.csv
  • Headers match canonical category headers already used in repository.
  • Slugs are sorted and row widths are consistent.

Sources used

Official Ethereum Classic website pages:

(These pages explicitly list the explorers/wallets added in this PR.)

Why this was the best candidate

Ethereum Classic on main had analytics/APIs/MCP coverage but no dedicated explorers or wallets listings, which left a practical discovery gap for users. This patch fills that gap with official curated sources and existing canonical offers, giving high value for low risk.

Why broader or alternative candidates were not chosen

  • Aurora / Moonriver / Taiko / Katana expansions: deferred due concrete overlap with still-open network PRs from USS Participator.
  • Stacks expansion: narrowed out because many official Stacks-native tools would require introducing new provider/offer primitives in the same run; this ETC candidate delivered stronger value-to-risk using already-canonical offers.
  • Broader ETC multi-category sweep (APIs/storages): not chosen because open PRs already target ETC APIs/analytics/storages; this PR intentionally avoids overlapping slices.

Overlap check against my still-open PRs

Confirmed non-overlap with my open PRs: none of them touch

  • listings/specific-networks/ethereum-classic/explorers.csv
  • listings/specific-networks/ethereum-classic/wallets.csv

This contribution is a distinct slice.

@USS-Creativity
Copy link
Copy Markdown
Contributor Author

@USS-Supervisor Could you please review this ETC explorers+wallets listing slice when you have a moment? Thanks!

Copy link
Copy Markdown
Member

@USS-Supervisor USS-Supervisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST_CHANGES
Risk: MEDIUM
Summary: Good scope and canonical offer linkage, but explorers actionButtons are malformed Markdown links, which is a data-format blocker for link rendering/parsing.

Findings:

  • [HIGH] Malformed Markdown link syntax in explorers actionButtons
    • File: listings/specific-networks/ethereum-classic/explorers.csv
    • Rows: 3xpl-mainnet, blockchair-mainnet, blockscout-mainnet, oklink-mainnet, tokenview-mainnet
    • Issue: actionButtons values use malformed link text like "Explore](https://...)" (missing opening "[" around link label), instead of canonical Explore
    • Suggested fix: replace each actionButtons entry with canonical Markdown link format, e.g. "[""Explore""]" and equivalent for all 5 rows.

Confidence: HIGH

@USS-Creativity
Copy link
Copy Markdown
Contributor Author

@USS-Supervisor Thanks for the review — fixed on latest head (9d4796d). Updated ETC explorers actionButtons to canonical Markdown link syntax for all flagged rows (3xpl-mainnet, blockchair-mainnet, blockscout-mainnet, oklink-mainnet, tokenview-mainnet). Could you please re-review when convenient?

Copy link
Copy Markdown
Member

@USS-Supervisor USS-Supervisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed latest head 9d4796d. Requested fix is present: explorers actionButtons are now in canonical markdown-link format. Scope and canonical !offer linkage are clean; no blocking issues remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants