Skip to content

Fix Specialize card image download from Scryfall #9952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Agetian merged 8 commits into from
Mar 1, 2026
Merged

Fix Specialize card image download from Scryfall #9952

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aa8bec7
Fix Specialize card image download from Scryfall
MostCromulent Feb 28, 2026
4fee95e
Use MagicColor for specialize face-to-suffix mapping
MostCromulent Mar 1, 2026
6c5dd07
Use MagicColor.Color enum directly for specialize suffix
MostCromulent Mar 1, 2026
d5feab7
Handle specialize image key suffixes in mobile ImageCache
MostCromulent Mar 1, 2026
c1128ce
Remove per-color getCardXSpecImageKey methods, use ImageUtil.getImage…
MostCromulent Mar 1, 2026
e1329fa
More cleanup
Mar 1, 2026
6f1dac4
Use interface
Mar 1, 2026
a3c97f9
Use interface
Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions forge-core/src/main/java/forge/util/ImageUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,13 @@ public static String getScryfallDownloadUrl(PaperCard cp, String face, String se
faceParam = (face.equals("back") && cp.getRules().getSplitType() != CardSplitType.Flip
? "&face=back"
: "&face=front");
} else if (cp.getRules().getSplitType() == CardSplitType.Specialize) {
// Specialize faces have their own Scryfall entries with collector
// number = base number + color letter (e.g. "2w", "2u", "2b", "2r", "2g")
String colorSuffix = specFaceToCollectorSuffix(face);
if (colorSuffix != null) {
cardCollectorNumber += colorSuffix;
}
}

if (cardCollectorNumber.endsWith("☇")) {
Expand All @@ -284,6 +291,17 @@ public static String getScryfallTokenDownloadUrl(String collectorNumber, String
langCode, versionParam, faceParam);
}

private static String specFaceToCollectorSuffix(String face) {
switch (face) {
case "white": return "w";
case "blue": return "u";
case "black": return "b";
case "red": return "r";
case "green": return "g";
default: return null;
}
}

private static String encodeUtf8(String s) {
try {
return URLEncoder.encode(s, "UTF-8");
Expand Down
10 changes: 5 additions & 5 deletions forge-game/src/main/java/forge/game/card/Card.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6360,19 +6360,19 @@ public final void setImageKey(final IPaperCard ipc, final CardStateName stateNam
return;
switch (stateName) {
case SpecializeB:
setImageKey(ipc.getCardBSpecImageKey());
setImageKey(ipc.getImageKey(false) + ImageKeys.SPECFACE_B);
break;
case SpecializeR:
setImageKey(ipc.getCardRSpecImageKey());
setImageKey(ipc.getImageKey(false) + ImageKeys.SPECFACE_R);
break;
case SpecializeG:
setImageKey(ipc.getCardGSpecImageKey());
setImageKey(ipc.getImageKey(false) + ImageKeys.SPECFACE_G);
break;
case SpecializeU:
setImageKey(ipc.getCardUSpecImageKey());
setImageKey(ipc.getImageKey(false) + ImageKeys.SPECFACE_U);
break;
case SpecializeW:
setImageKey(ipc.getCardWSpecImageKey());
setImageKey(ipc.getImageKey(false) + ImageKeys.SPECFACE_W);
break;
default:
break;
Expand Down