Add card info tooltips with keyword explanations and related cards

forge-game/src/main/java/forge/game/keyword/KeywordAction.java

@@ -0,0 +1,161 @@
+package forge.game.keyword;
+
+import forge.util.Localizer;
+
+/**
+ * Keyword actions — verbs that appear in rules text but aren't keyword abilities.
+ * Descriptions are based on the MTG comprehensive rules (section 701).
+ *
+ * <p>Unlike {@link Keyword} (keyword abilities that grant continuous effects or
+ * triggered/static abilities), keyword actions are one-shot game actions performed
+ * when instructed by a spell or ability.</p>
+ *
+ * <p>Actions marked {@code basic=true} are fundamental game actions (destroy, exile,
+ * sacrifice, etc.) that every player knows — UI code may choose to omit these from
+ * tooltips to avoid clutter.</p>
+ *
+ * <p>Display names and reminder text are stored in {@code en-US.properties} under
+ * keys derived from the enum name (e.g. {@code lblKwActionActivate},
+ * {@code lblKwActionActivateReminder}).</p>
+ */
+public enum KeywordAction {
+    // 701.2 – 701.13: Basic game actions
+    ACTIVATE(true),
+    ATTACH(true),
+    BEHOLD(false),
+    CAST(true),
+    COUNTER(true),
+    CREATE(true),
+    DESTROY(true),
+    DISCARD(true),
+    DOUBLE(true),
+    TRIPLE(true),
+    EXCHANGE(true),
+    EXILE(true),
+
+    // 701.14 – 701.17: Combat & graveyard actions
+    FIGHT(false),
+    GOAD(false),
+    INVESTIGATE(false),
+    MILL(false),
+
+    // 701.18 – 701.21: More basic actions
+    PLAY(true),
+    REGENERATE(false),
+    REVEAL(true),
+    SACRIFICE(true),
+
+    // 701.22 – 701.28: Library & transform actions
+    SCRY(false),
+    SEARCH(true),
+    SHUFFLE(true),
+    SURVEIL(false),
+    TAP_UNTAP(true),
+    TRANSFORM(false),
+    CONVERT(false),
+
+    // 701.29 – 701.30: Opponent manipulation
+    FATESEAL(false),
+    CLASH(false),
+
+    // 701.31 – 701.33: Supplemental format actions
+    PLANESWALK(false),
+    SET_IN_MOTION(false),
+    ABANDON(false),
+
+    // 701.34 – 701.36: Counter & token actions
+    PROLIFERATE(false),
+    DETAIN(false),
+    POPULATE(false),
+
+    // 701.37 – 701.39: Creature enhancement
+    MONSTROSITY(false),
+    VOTE(false),
+    BOLSTER(false),
+
+    // 701.40 – 701.44: Face-down & explore
+    MANIFEST(false),
+    SUPPORT(false),
+    MELD(false),
+    EXERT(false),
+    EXPLORE(false),
+
+    // 701.45 – 701.48: Un-set & learning
+    ASSEMBLE(false),
+    ADAPT(false),
+    AMASS(false),
+    LEARN(false),
+
+    // 701.49 – 701.50: Dungeon & connive
+    VENTURE(false),
+    CONNIVE(false),
+
+    // 701.51 – 701.52: Attraction actions
+    OPEN_AN_ATTRACTION(false),
+    ROLL_TO_VISIT(false),
+
+    // 701.53 – 701.54: Incubate & ring
+    INCUBATE(false),
+    THE_RING_TEMPTS_YOU(false),
+
+    // 701.55 – 701.56: Villainous choice & time travel
+    FACE_A_VILLAINOUS_CHOICE(false),
+    TIME_TRAVEL(false),
+
+    // 701.57 – 701.60: Discover, cloak, evidence, suspect
+    DISCOVER(false),
+    CLOAK(false),
+    COLLECT_EVIDENCE(false),
+    SUSPECT(false),
+
+    // 701.61 – 701.64: Bloomburrow & beyond
+    FORAGE(false),
+    MANIFEST_DREAD(false),
+    ENDURE(false),
+    HARNESS(false),
+
+    // 701.65 – 701.68: Avatar & Lorwyn Eclipsed
+    AIRBEND(false),
+    EARTHBEND(false),
+    WATERBEND(false),
+    BLIGHT(false);
+
+    /** True for fundamental game actions (destroy, exile, sacrifice, etc.) that don't need tooltip explanations. */
+    public final boolean basic;
+    /** Translation key prefix derived from enum name, e.g. "lblKwActionActivate". */
+    private final String translationKey;
+
+    KeywordAction(boolean basic) {
+        this.basic = basic;
+        this.translationKey = "lblKwAction" + toCamelCase(name());
+    }
+
+    private static String toCamelCase(String enumName) {
+        StringBuilder sb = new StringBuilder();
+        boolean capitalize = true;
+        for (char c : enumName.toCharArray()) {
+            if (c == '_') {
+                capitalize = true;
+            } else {
+                sb.append(capitalize ? c : Character.toLowerCase(c));
+                capitalize = false;
+            }
+        }
+        return sb.toString();
+    }
+
+    /** Returns the localized display name. */
+    public String getDisplayName() {
+        return Localizer.getInstance().getMessage(translationKey);
+    }
+
+    /** Returns the localized reminder text. */
+    public String getReminderText() {
+        return Localizer.getInstance().getMessage(translationKey + "Reminder");
+    }
+
+    @Override
+    public String toString() {
+        return getDisplayName();
+    }
+}

forge-game/src/main/java/forge/game/keyword/Protection.java

@@ -10,6 +10,7 @@ public String getTitle() {
 
     @Override
     protected void parse(String details) {
+        fromWhat = details.startsWith("from ") ? details.substring(5) : details;
     }
 
     @Override

forge-gui-desktop/src/main/java/forge/CachedCardImage.java

@@ -14,7 +14,7 @@ public abstract class CachedCardImage implements ImageFetcher.Callback {
     final int width;
     final int height;
 
-    static final SwingImageFetcher fetcher = new SwingImageFetcher();
+    public static final SwingImageFetcher fetcher = new SwingImageFetcher();
 
     public CachedCardImage(final CardView card, final Iterable<PlayerView> viewers, final int width, final int height) {
         this.card = card;

forge-gui-desktop/src/main/java/forge/ImageCache.java

@@ -200,6 +200,10 @@ public static Pair<BufferedImage, Boolean> getCardOriginalImageInfo(String image
         return getOriginalImageInternal(imageKey, useDefaultIfNotFound, null);
     }
 
+    public static Pair<BufferedImage, Boolean> getCardOriginalImageInfo(String imageKey, boolean useDefaultIfNotFound, CardView cardView) {
+        return getOriginalImageInternal(imageKey, useDefaultIfNotFound, cardView);
+    }
+
     // return the pair of image and a flag to indicate if it is a placeholder image.
     private static Pair<BufferedImage, Boolean> getOriginalImageInternal(String imageKey, boolean useDefaultIfNotFound,
                                                                          CardView cardView) {

forge-gui-desktop/src/main/java/forge/screens/home/settings/CSubmenuPreferences.java

@@ -155,6 +155,8 @@ public void initialize() {
         lstControls.add(Pair.of(view.getCbOpenPacksIndiv(), FPref.UI_OPEN_PACKS_INDIV));
         lstControls.add(Pair.of(view.getCbTokensInSeparateRow(), FPref.UI_TOKENS_IN_SEPARATE_ROW));
         lstControls.add(Pair.of(view.getCbStackCreatures(), FPref.UI_STACK_CREATURES));
+        lstControls.add(Pair.of(view.getCbPopupKeywordInfo(), FPref.UI_POPUP_KEYWORD_INFO));
+        lstControls.add(Pair.of(view.getCbPopupRelatedCards(), FPref.UI_POPUP_RELATED_CARDS));
         lstControls.add(Pair.of(view.getCbManaLostPrompt(), FPref.UI_MANA_LOST_PROMPT));
         lstControls.add(Pair.of(view.getCbEscapeEndsTurn(), FPref.UI_ALLOW_ESC_TO_END_TURN));
         lstControls.add(Pair.of(view.getCbDetailedPaymentDesc(), FPref.UI_DETAILED_SPELLDESC_IN_PROMPT));

forge-gui-desktop/src/main/java/forge/screens/home/settings/VSubmenuPreferences.java

@@ -110,6 +110,8 @@ public enum VSubmenuPreferences implements IVSubmenu<CSubmenuPreferences> {
     private final JCheckBox cbOpenPacksIndiv = new OptionsCheckBox(localizer.getMessage("cbOpenPacksIndiv"));
     private final JCheckBox cbTokensInSeparateRow = new OptionsCheckBox(localizer.getMessage("cbTokensInSeparateRow"));
     private final JCheckBox cbStackCreatures = new OptionsCheckBox(localizer.getMessage("cbStackCreatures"));
+    private final JCheckBox cbPopupKeywordInfo = new OptionsCheckBox(localizer.getMessage("cbPopupKeywordInfo"));
+    private final JCheckBox cbPopupRelatedCards = new OptionsCheckBox(localizer.getMessage("cbPopupRelatedCards"));
     private final JCheckBox cbFilterLandsByColorId = new OptionsCheckBox(localizer.getMessage("cbFilterLandsByColorId"));
     private final JCheckBox cbShowStormCount = new OptionsCheckBox(localizer.getMessage("cbShowStormCount"));
     private final JCheckBox cbRemindOnPriority = new OptionsCheckBox(localizer.getMessage("cbRemindOnPriority"));
@@ -439,6 +441,12 @@ public enum VSubmenuPreferences implements IVSubmenu<CSubmenuPreferences> {
         pnlPrefs.add(cbStackCreatures, titleConstraints);
         pnlPrefs.add(new NoteLabel(localizer.getMessage("nlStackCreatures")), descriptionConstraints);
 
+        pnlPrefs.add(cbPopupKeywordInfo, titleConstraints);
+        pnlPrefs.add(new NoteLabel(localizer.getMessage("nlPopupKeywordInfo")), descriptionConstraints);
+
+        pnlPrefs.add(cbPopupRelatedCards, titleConstraints);
+        pnlPrefs.add(new NoteLabel(localizer.getMessage("nlPopupRelatedCards")), descriptionConstraints);
+
         pnlPrefs.add(cbTimedTargOverlay, titleConstraints);
         pnlPrefs.add(new NoteLabel(localizer.getMessage("nlTimedTargOverlay")), descriptionConstraints);
 
@@ -993,6 +1001,14 @@ public final JCheckBox getCbStackCreatures() {
         return cbStackCreatures;
     }
 
+    public final JCheckBox getCbPopupKeywordInfo() {
+        return cbPopupKeywordInfo;
+    }
+
+    public final JCheckBox getCbPopupRelatedCards() {
+        return cbPopupRelatedCards;
+    }
+
     public final JCheckBox getCbManaLostPrompt() {
     	return cbManaLostPrompt;
     }

forge-gui-desktop/src/main/java/forge/screens/match/menus/CardInfoPopupMenu.java

@@ -0,0 +1,123 @@
+package forge.screens.match.menus;
+
+import java.awt.BorderLayout;
+import java.awt.Color;
+import java.awt.Font;
+import java.awt.event.MouseEvent;
+
+import javax.swing.JCheckBoxMenuItem;
+import javax.swing.JMenu;
+import javax.swing.JMenuItem;
+import javax.swing.JPanel;
+import javax.swing.JSeparator;
+import javax.swing.SwingConstants;
+
+import forge.localinstance.properties.ForgePreferences;
+import forge.localinstance.properties.ForgePreferences.FPref;
+import forge.model.FModel;
+import forge.toolbox.FSkin;
+import forge.toolbox.FSkin.SkinnedLabel;
+import forge.toolbox.FSkin.SkinnedSlider;
+import forge.util.Localizer;
+
+/**
+ * Submenu under the Game menu for toggling card info popup sections
+ * (keyword explanations and related cards) during a match.
+ */
+public final class CardInfoPopupMenu {
+    private static final ForgePreferences prefs = FModel.getPreferences();
+
+    public CardInfoPopupMenu() {
+    }
+
+    public JMenu getMenu() {
+        final Localizer localizer = Localizer.getInstance();
+        final JMenu menu = new JMenu(localizer.getMessage("lblCardInfoPopups"));
+
+        // --- Hover Tooltip section ---
+        menu.add(createSectionHeader(localizer.getMessage("lblHoverTooltip")));
+        menu.add(getCheckboxItem(localizer.getMessage("lblCardImage"),
+                FPref.UI_POPUP_CARD_IMAGE));
+        menu.add(getCheckboxItem(localizer.getMessage("lblRelatedCards"),
+                FPref.UI_POPUP_RELATED_CARDS));
+        menu.add(getCheckboxItem(localizer.getMessage("lblKeywordExplanations"),
+                FPref.UI_POPUP_KEYWORD_INFO));
+
+        menu.add(new JSeparator());
+
+        // --- Card Zoom View section ---
+        menu.add(createSectionHeader(localizer.getMessage("lblCardZoomView")));
+        menu.add(getCheckboxItem(localizer.getMessage("lblRelatedCards"),
+                FPref.UI_ZOOM_RELATED_CARDS));
+        menu.add(getCheckboxItem(localizer.getMessage("lblKeywordExplanations"),
+                FPref.UI_ZOOM_KEYWORD_INFO));
+
+        menu.add(new JSeparator());
+        menu.add(buildImageSizePanel(localizer));
+        return menu;
+    }
+
+    private static JMenuItem createSectionHeader(final String text) {
+        final JMenuItem header = new JMenuItem(text);
+        header.setEnabled(false);
+        header.setFont(header.getFont().deriveFont(Font.BOLD));
+        return header;
+    }
+
+    private static JCheckBoxMenuItem getCheckboxItem(final String label, final FPref pref) {
+        final JCheckBoxMenuItem item = new JCheckBoxMenuItem(label) {
+            @Override
+            protected void processMouseEvent(final MouseEvent e) {
+                if (e.getID() == MouseEvent.MOUSE_RELEASED && contains(e.getPoint())) {
+                    doClick(0);
+                    setArmed(true);
+                } else {
+                    super.processMouseEvent(e);
+                }
+            }
+        };
+        item.setState(prefs.getPrefBoolean(pref));
+        item.addActionListener(e -> {
+            final boolean newState = !prefs.getPrefBoolean(pref);
+            prefs.setPref(pref, newState);
+            prefs.save();
+        });
+        return item;
+    }
+
+    private static JPanel buildImageSizePanel(final Localizer localizer) {
+        final Color bg = FSkin.getColor(FSkin.Colors.CLR_THEME2).getColor();
+        final Color fg = FSkin.getColor(FSkin.Colors.CLR_TEXT).getColor();
+        final int rawValue = prefs.getPrefInt(FPref.UI_POPUP_IMAGE_SIZE);
+        final int currentValue = Math.max(100, Math.min(500, rawValue));
+
+        final JPanel panel = new JPanel(new BorderLayout());
+        panel.setBackground(bg);
+
+        final SkinnedLabel label = new SkinnedLabel();
+        label.setText(localizer.getMessage("lblImageSize"));
+        label.setForeground(fg);
+        label.setFont(FSkin.getFont());
+        label.setOpaque(true);
+        label.setBackground(bg);
+
+        final SkinnedSlider slider = new SkinnedSlider(SwingConstants.HORIZONTAL, 100, 500, currentValue);
+        slider.setMajorTickSpacing(100);
+        slider.setMinorTickSpacing(20);
+        slider.setPaintTicks(true);
+        slider.setPaintLabels(true);
+        slider.setBackground(bg);
+        slider.setForeground(fg);
+        slider.setFont(FSkin.getFont());
+
+        slider.addChangeListener(e -> {
+            slider.repaint();
+            prefs.setPref(FPref.UI_POPUP_IMAGE_SIZE, String.valueOf(slider.getValue()));
+            prefs.save();
+        });
+
+        panel.add(label, BorderLayout.NORTH);
+        panel.add(slider, BorderLayout.CENTER);
+        return panel;
+    }
+}

forge-gui-desktop/src/main/java/forge/screens/match/menus/GameMenu.java

@@ -48,6 +48,7 @@ public JMenu getMenu() {
         menu.addSeparator();
         menu.add(getMenuItem_TargetingArcs());
         menu.add(new CardOverlaysMenu(matchUI).getMenu());
+        menu.add(new CardInfoPopupMenu().getMenu());
         menu.add(getMenuItem_AutoYields());
         menu.addSeparator();
         menu.add(getMenuItem_ViewDeckList());