Skip to content

Chaos mode in Realm of Legends - generate valid Commander decks #10224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Agetian merged 4 commits into from
Apr 2, 2026
Merged

Chaos mode in Realm of Legends - generate valid Commander decks #10224

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbfad0a
Remove Chaos mode option from Realm of Legends new game screen
MostCromulent Mar 31, 2026
4bbed28
Generate valid Commander decks for Chaos mode instead of disabling it
MostCromulent Mar 31, 2026
f7134e4
Merge branch 'master' into rolchaosfix
Agetian Apr 2, 2026
3d9a982
Simplify isCommanderLike() to use a single return statement
MostCromulent Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions forge-gui-mobile/src/forge/adventure/data/ConfigData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public class ConfigData {
public String[] allowedJumpstart;
public String defaultBasicLandSet = "JMP";
public boolean enableGeneticAI = true;
public String chaosDeckFormat;
public boolean usePriceListPrices = true;

}
3 changes: 2 additions & 1 deletion forge-gui-mobile/src/forge/adventure/util/AdventureModes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ public Array<String> getModes() {
}

public boolean isCommanderLike() {
return this == Commander || this == CommanderPrecon;
if (this == Commander || this == CommanderPrecon) return true;
return this == Chaos && "Commander".equalsIgnoreCase(Config.instance().getConfigData().chaosDeckFormat);
Copy link
Copy Markdown
Contributor

@Agetian Agetian Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe can be simplified to a single return statement? If a single line is too long, a boolean can be introduced determining the Chaos Commander setting, and then a return with three "or"ed statements (this == Commander || this == CommanderPrecon || isChaosCommander)

}

public boolean usesFolderDeckPicker() {
Expand Down
4 changes: 4 additions & 0 deletions forge-gui-mobile/src/forge/adventure/util/CardUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import forge.deck.DeckgenUtil;
import forge.deck.io.DeckSerializer;
import forge.game.GameFormat;
import forge.game.GameType;
import forge.item.BoosterPack;
import forge.item.PaperCard;
import forge.item.PaperCardPredicates;
Expand Down Expand Up @@ -750,6 +751,9 @@ public static Deck getDeck(String path, boolean forAI, boolean isFantasyMode, St
}

if (forAI && (isFantasyMode || useGeneticAI)) {
if (isFantasyMode && "Commander".equalsIgnoreCase(Config.instance().getConfigData().chaosDeckFormat)) {
return DeckgenUtil.generateCommanderDeck(true, GameType.Commander);
}
return DeckgenUtil.getRandomOrPreconOrThemeDeck(colors, forAI, isTheme, useGeneticAI);
}

Expand Down
4 changes: 4 additions & 0 deletions forge-gui-mobile/src/forge/adventure/util/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import forge.deck.Deck;
import forge.deck.DeckProxy;
import forge.deck.DeckgenUtil;
import forge.game.GameType;
import forge.gui.GuiBase;
import forge.item.PaperCard;
import forge.localinstance.properties.ForgeConstants;
Expand Down Expand Up @@ -257,6 +258,9 @@ public Deck starterDeck(ColorSet color, DifficultyData difficultyData, Adventure
}
}
case Chaos:
if ("Commander".equalsIgnoreCase(configData.chaosDeckFormat)) {
return DeckgenUtil.generateCommanderDeck(false, GameType.Commander);
}
return DeckgenUtil.getRandomOrPreconOrThemeDeck("", false, false, false, configData.allowedEditions);
case Custom:
return DeckProxy.getAllCustomStarterDecks().get(index).getDeck();
Expand Down
1 change: 1 addition & 0 deletions forge-gui/res/adventure/Realm of Legends/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@
"CN2"
],
"usePriceListPrices": false,
"chaosDeckFormat": "Commander",
"difficulties": [
{
"name": "Easy",
Expand Down
Loading