Skip to content

ImproveReactorSurface handling and reimplement advanceCoverages #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ischoegl merged 11 commits into from
Jan 31, 2026

[CI] Ensure sample running output makes it to logs

8089b25
Select commit
Loading
Failed to load commit list.
Merged

ImproveReactorSurface handling and reimplement advanceCoverages #2075

[CI] Ensure sample running output makes it to logs
8089b25
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2026 in 0s

77.34% (+0.13%) compared to bd8f886

View this Pull Request on Codecov

77.34% (+0.13%) compared to bd8f886

Details

Codecov Report

❌ Patch coverage is 89.96416% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.34%. Comparing base (bd8f886) to head (8089b25).

Files with missing lines Patch % Lines
src/zeroD/ReactorNet.cpp 89.31% 2 Missing and 12 partials ⚠️
include/cantera/zeroD/ReactorBase.h 0.00% 5 Missing ⚠️
src/numerics/CVodesIntegrator.cpp 69.23% 3 Missing and 1 partial ⚠️
src/kinetics/InterfaceKinetics.cpp 94.11% 1 Missing and 1 partial ⚠️
src/zeroD/IdealGasConstPressureReactor.cpp 75.00% 1 Missing and 1 partial ⚠️
include/cantera/zeroD/FlowReactor.h 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2075      +/-   ##
==========================================
+ Coverage   77.21%   77.34%   +0.13%     
==========================================
  Files         456      451       -5     
  Lines       52952    52494     -458     
  Branches     8966     8847     -119     
==========================================
- Hits        40885    40602     -283     
+ Misses       9041     8917     -124     
+ Partials     3026     2975      -51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov