Skip to content

Simplify Reactor evaluation/synchronization logic #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ischoegl merged 17 commits into from
Jan 28, 2026

[Python/Reactor] Check for attempts to assign unknown delegates

9fae77d
Select commit
Loading
Failed to load commit list.
Merged

Simplify Reactor evaluation/synchronization logic #2069

[Python/Reactor] Check for attempts to assign unknown delegates
9fae77d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 25, 2026 in 0s

77.17% (-0.05%) compared to 630ba99

View this Pull Request on Codecov

77.17% (-0.05%) compared to 630ba99

Details

Codecov Report

❌ Patch coverage is 78.13051% with 124 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.17%. Comparing base (630ba99) to head (9fae77d).

Files with missing lines Patch % Lines
include/cantera/zeroD/ReactorBase.h 22.91% 37 Missing ⚠️
interfaces/cython/cantera/jacobians.pyx 23.07% 10 Missing ⚠️
src/zeroD/ReactorFactory.cpp 76.19% 9 Missing and 1 partial ⚠️
include/cantera/zeroD/ReactorDelegator.h 47.05% 9 Missing ⚠️
include/cantera/zeroD/ReactorSurface.h 61.90% 8 Missing ⚠️
interfaces/cython/cantera/reactor.pyx 82.97% 8 Missing ⚠️
src/zeroD/ReactorSurface.cpp 93.38% 4 Missing and 4 partials ⚠️
src/zeroD/ReactorNet.cpp 91.76% 0 Missing and 7 partials ⚠️
src/zeroD/IdealGasMoleReactor.cpp 71.42% 6 Missing ⚠️
src/zeroD/ConstPressureMoleReactor.cpp 54.54% 5 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2069      +/-   ##
==========================================
- Coverage   77.22%   77.17%   -0.05%     
==========================================
  Files         456      456              
  Lines       53026    52870     -156     
  Branches     8998     8951      -47     
==========================================
- Hits        40947    40805     -142     
- Misses       9035     9045      +10     
+ Partials     3044     3020      -24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov