Skip to content

Extensible jacobian and network jacobian interfaces #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anthony-walker wants to merge 13 commits into
base: main
Choose a base branch
from

[Reactor] Fix duplicate calculation of connector Jacobians

e899b21
Select commit
Loading
Failed to load commit list.
Open

Extensible jacobian and network jacobian interfaces #1634

[Reactor] Fix duplicate calculation of connector Jacobians
e899b21
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 31, 2026 in 0s

76.78% (+0.03%) compared to 3d86636

View this Pull Request on Codecov

76.78% (+0.03%) compared to 3d86636

Details

Codecov Report

❌ Patch coverage is 83.01887% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.78%. Comparing base (3d86636) to head (e899b21).
⚠️ Report is 168 commits behind head on main.

Files with missing lines Patch % Lines
src/zeroD/ReactorNet.cpp 85.71% 4 Missing and 5 partials ⚠️
include/cantera/zeroD/ReactorBase.h 0.00% 4 Missing ⚠️
include/cantera/zeroD/Wall.h 0.00% 4 Missing ⚠️
src/zeroD/Reactor.cpp 77.77% 2 Missing and 2 partials ⚠️
interfaces/cython/cantera/delegator.pyx 75.00% 3 Missing ⚠️
src/zeroD/Wall.cpp 91.42% 0 Missing and 3 partials ⚠️
include/cantera/base/Delegator.h 71.42% 1 Missing and 1 partial ⚠️
include/cantera/zeroD/Reactor.h 0.00% 2 Missing ⚠️
src/zeroD/IdealGasConstPressureMoleReactor.cpp 83.33% 2 Missing ⚠️
src/zeroD/IdealGasMoleReactor.cpp 83.33% 2 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1634      +/-   ##
==========================================
+ Coverage   76.75%   76.78%   +0.03%     
==========================================
  Files         457      458       +1     
  Lines       53744    53929     +185     
  Branches     9122     9151      +29     
==========================================
+ Hits        41250    41411     +161     
- Misses       9386     9400      +14     
- Partials     3108     3118      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov