Skip to content

test: multi-domain docs + programs#29

Closed
CamSoper wants to merge 2 commits intomasterfrom
test-pipeline/multi-domain
Closed

test: multi-domain docs + programs#29
CamSoper wants to merge 2 commits intomasterfrom
test-pipeline/multi-domain

Conversation

@CamSoper
Copy link
Copy Markdown
Owner

Pipeline test: mixed-domain PR (content/docs/ + static/programs/). Triage should label review:docs + review:programs + review:mixed + fact-check:needed. Review should compose both domain files.

Fork-only tweak so claude.yml works without org-side ESC setup.
@claude retains all its capabilities (re-entrant reviews, Q&A,
make-changes on PRs) -- only difference is commits pushed with
GITHUB_TOKEN don't trigger downstream workflows, which is fine for
fork testing.

This commit is NOT for upstream. Origin/master and pulumi#18680
keep the ESC design. Do not cherry-pick.
Pipeline-test PR: docs edit plus a minimal TS program to exercise
review:mixed triage + multi-domain composition.
@CamSoper CamSoper marked this pull request as ready for review April 23, 2026 22:39
@github-actions github-actions Bot added review:docs PR touches technical docs review:mixed PR touches more than one domain review:programs PR touches static/programs/ fact-check:needed PR introduces factual claims; fact-check runs labels Apr 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

🐿️ Review errored. Flip to draft and back to ready, or mention @claude, to retry.

@github-actions github-actions Bot added review:claude-working Claude is running a review right now; auto-removed when finishes and removed review:claude-working Claude is running a review right now; auto-removed when finishes labels Apr 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

🐿️ Review updated.

@github-actions github-actions Bot added the review:claude-working Claude is running a review right now; auto-removed when finishes label Apr 23, 2026
@claude
Copy link
Copy Markdown

claude Bot commented Apr 23, 2026

Claude Review — Last updated 2026-04-23T22:43:21Z

🚨 Outstanding ⚠️ Low-confidence 💡 Pre-existing ✅ Resolved
2 2 0 0

🚨 Outstanding in this PR

  • content/docs/iac/concepts/assets-archives.md:355-358 — test content added to a production docs page.
    The new H2 "Multi-domain test section" is a self-describing placeholder ("This section was added alongside a new program in static/programs/multi-domain-bucket-typescript/ to exercise mixed-domain review."). If this merges, it renders on the public /docs/iac/concepts/assets-archives/ page with no reader value. Either remove the section before merging or replace the body with real content that a docs reader would expect after the Assets & Archives material.

  • static/programs/multi-domain-bucket-typescript/Pulumi.yaml:3 — placeholder description.
    description: Multi-domain-test program. describes the program's role in this pipeline test, not what the program demonstrates. Every other program in static/programs/ carries a description a docs reader could use. Replace with something like:

    description: Minimal S3 bucket example in TypeScript.
    

⚠️ Low-confidence

  • scripts/programs/ignore.txt:58-59 — new program opted out of the test harness.
    Adding multi-domain-bucket-typescript to ignore.txt means ./scripts/programs/test.sh will skip it on every CI run, so compilability drift won't be caught. The other entries in the file either have explicit justifications (regex patterns for intentionally-broken variants, the tf-state-ref-terraform non-Pulumi fixture) or fall into established patterns. If this skip is intentional for the pipeline test, add a short comment above the entry matching the style of the surrounding block so a future maintainer doesn't have to guess. If unintentional, remove the entry so the harness picks it up.

  • static/programs/multi-domain-bucket-typescript/ — no package-lock.json (or yarn.lock).
    Per .claude/commands/_common/review-programs.md §Project structure, TypeScript programs should ship package.json + package-lock.json (or yarn.lock). The PR adds only package.json. This may be intentional if this repo's convention is "lock files aren't committed for example programs," hence low-confidence — but the rubric calls for one, and its absence will let transitive-dep drift silently change what this example resolves to.

📜 Review history

  • 2026-04-23T22:43:21Z — Initial review: 2 outstanding (test content in docs page; placeholder program description), 2 low-confidence (test-harness opt-out; missing lock file). (632d130)

Pushed a fix? Mention @claude to refresh. Think a finding is wrong? Mention @claude with your reasoning — disputes are welcome, and Claude will concede on evidence. See AGENTS.md §PR Lifecycle for the re-entrant workflow.

@claude claude Bot added the review:claude-ran Claude review has completed for this PR's current state label Apr 23, 2026
@github-actions github-actions Bot removed the review:claude-working Claude is running a review right now; auto-removed when finishes label Apr 23, 2026
@CamSoper
Copy link
Copy Markdown
Owner Author

Test PR closed. The Claude PR review pipeline work is now tracked on pulumi#18680.

@CamSoper CamSoper closed this Apr 23, 2026
@CamSoper CamSoper deleted the test-pipeline/multi-domain branch April 23, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fact-check:needed PR introduces factual claims; fact-check runs review:claude-ran Claude review has completed for this PR's current state review:docs PR touches technical docs review:mixed PR touches more than one domain review:programs PR touches static/programs/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant