Closed
Conversation
CamSoper
added a commit
that referenced
this pull request
Apr 23, 2026
gh pr view's --json field for author is 'author' (returns .author.login), not 'user'. And headRefOid wasn't used anywhere. Both caused the field validator to reject the whole --json argument, which exited non-zero and dumped the full field list to the log. Caught during the first end-to-end test of the chained review on PR #27.
|
🐿️ Review updated. |
Claude Review — Last updated 2026-04-23T21:05:13Z
🚨 Outstanding in this PRNone.
|
84d8cdc to
00a0780
Compare
Fork-only tweak so claude.yml works without org-side ESC setup. @claude retains all its capabilities (re-entrant reviews, Q&A, make-changes on PRs) -- only difference is commits pushed with GITHUB_TOKEN don't trigger downstream workflows, which is fine for fork testing. This commit is NOT for upstream. Origin/master and pulumi#18680 keep the ESC design. Do not cherry-pick.
- Add 'set -euo pipefail' so transient yarn/hugo failures surface instead of getting swallowed. - Also clean tmp/ and yarn-error.log.
a89de5e to
0ec277d
Compare
Owner
Author
|
Test PR closed. The Claude PR review pipeline work is now tracked on pulumi#18680. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 'set -euo pipefail' so yarn / hugo failures stop propagating, and cleans tmp/ and yarn-error.log on top of the existing targets.
Pipeline test: exercises the
review:infradomain path and the new triage → workflow_run chained review. Opens as draft so triage fires but the chained review skips (is_draft=true); flipping to ready should fire both.