Cacti · somethingwithproof · Apr 9, 2026 · Apr 9, 2026 · Apr 10, 2026 · Apr 10, 2026
diff --git a/.github/workflows/php-syntax.yml b/.github/workflows/php-syntax.yml
@@ -0,0 +1,52 @@
+name: PHP Syntax
+
+on:
+  pull_request:
+  push:
+    branches:
+      - develop
+
+permissions:
+  contents: read
+
+concurrency:
+  group: php-syntax-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  lint:
+    name: PHP ${{ matrix.php }} syntax
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        php: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+          tools: none
+          coverage: none
+
+      - name: Show PHP version
+        run: php -v
+
+      - name: Guard against corrupted refactor patterns
+        run: |
+          set -euo pipefail
+          if grep -R -n -E '\b(is_|in_|call_user_func_|port_list_to_|mactrack_display_|mactrack_device_action_)\[' --include='*.php' .; then
+            echo "Detected corrupted call-pattern rewrite(s)." >&2
+            exit 1
+          fi
+
+      - name: Lint PHP files
+        run: |
+          set -euo pipefail
+          git ls-files '*.php' | while IFS= read -r f; do
+            php -l "$f"
+          done
diff --git a/.gitignore b/.gitignore
@@ -20,3 +20,4 @@
 # +-------------------------------------------------------------------------+
 
 locales/po/*.mo
+.omc/
diff --git a/images/index.php b/images/index.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/includes/database.php b/includes/database.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/index.php b/index.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/index.php b/lib/index.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_3com.php b/lib/mactrack_3com.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_aruba_oscx.php b/lib/mactrack_aruba_oscx.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_cabletron.php b/lib/mactrack_cabletron.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_cisco.php b/lib/mactrack_cisco.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_dell.php b/lib/mactrack_dell.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_dlink.php b/lib/mactrack_dlink.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_enterasys.php b/lib/mactrack_enterasys.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_enterasys_N7.php b/lib/mactrack_enterasys_N7.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_extreme.php b/lib/mactrack_extreme.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_foundry.php b/lib/mactrack_foundry.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_functions.php b/lib/mactrack_functions.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_h3c_3com.php b/lib/mactrack_h3c_3com.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_hp.php b/lib/mactrack_hp.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_hp_ng.php b/lib/mactrack_hp_ng.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_hp_ngi.php b/lib/mactrack_hp_ngi.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_juniper.php b/lib/mactrack_juniper.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_linux.php b/lib/mactrack_linux.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_norbay.php b/lib/mactrack_norbay.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_norbay_ng.php b/lib/mactrack_norbay_ng.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_tplink.php b/lib/mactrack_tplink.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_trendnet.php b/lib/mactrack_trendnet.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/lib/mactrack_vendors.php b/lib/mactrack_vendors.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/locales/LC_MESSAGES/index.php b/locales/LC_MESSAGES/index.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/locales/index.php b/locales/index.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/locales/po/index.php b/locales/po/index.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_actions.php b/mactrack_actions.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_ajax.php b/mactrack_ajax.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_ajax_admin.php b/mactrack_ajax_admin.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_convert.php b/mactrack_convert.php
@@ -193,15 +193,15 @@ function mactrack_create_partitioned_table($engine = 'InnoDB', $charset, $collat
 						SELECT *
 						FROM mac_track_ports_backups
 						WHERE scan_date = ?',
-						array($sd['scan_date']));
+						[$sd['scan_date']]);
 
 					db_execute_prepared('DELETE FROM mac_track_ports_backup
 						WHERE scan_date = ?',
-						array($sd['scan_date']));
+						[$sd['scan_date']]);
 				}
 			}
 			*/
-			db_execute('INSERT mac_track_ports SELECT * FROM mac_track_ports_backup');
+			db_execute_prepared('INSERT INTO mac_track_ports SELECT * FROM mac_track_ports_backup');
 		}
 
 		db_execute('DROP TABLE mac_track_ports_backup');

diff --git a/mactrack_device_types.php b/mactrack_device_types.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_devices.php b/mactrack_devices.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_import_ouidb.php b/mactrack_import_ouidb.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_macauth.php b/mactrack_macauth.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_macwatch.php b/mactrack_macwatch.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_resolver.php b/mactrack_resolver.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_scanner.php b/mactrack_scanner.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_sites.php b/mactrack_sites.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_snmp.php b/mactrack_snmp.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_utilities.php b/mactrack_utilities.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_vendormacs.php b/mactrack_vendormacs.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_view_arp.php b/mactrack_view_arp.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_view_devices.php b/mactrack_view_devices.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

diff --git a/mactrack_view_dot1x.php b/mactrack_view_dot1x.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types = 1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |
Original file line number	Diff line number	Diff line change
Expand Up		@@ -20,3 +20,4 @@
		# +-------------------------------------------------------------------------+

		locales/po/*.mo
		.omc/