Added configs to be part of Caliper metadata#209
Open
amroakmal wants to merge 1 commit intoCEED:masterfrom
Open
Added configs to be part of Caliper metadata#209amroakmal wants to merge 1 commit intoCEED:masterfrom
amroakmal wants to merge 1 commit intoCEED:masterfrom
Conversation
Author
|
@rfhaque : May you please review this PR? The goal is to add missing configs/params to Caliper metadata using Aidak. Please advise if there’re any changes needed. |
amroakmal
force-pushed
the
add-configs-to-metadata
branch
3 times, most recently
from
48da628 to
82e4c1b
Compare
amroakmal
force-pushed
the
add-configs-to-metadata
branch
from
82e4c1b to
eb5daad
Compare
daboehme
reviewed
Mar 19, 2026
| MPI_Comm adiak_mpi_comm = MPI_COMM_WORLD; | ||
| void* adiak_mpi_comm_ptr = &adiak_mpi_comm; | ||
| adiak::init(adiak_mpi_comm_ptr); | ||
| adiak::launchdate(); |
There was a problem hiding this comment.
We should use adiak::collect_all() here to collect all the built-in metadata
pearce8
suggested changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.