Conversation
Collaborator
|
It looks good to me and the results match what I was getting before. |
ioanaapapa
approved these changes
Apr 22, 2026
Collaborator
ioanaapapa
left a comment
There was a problem hiding this comment.
It looks good to me and the results match what I was getting before.
jimboid
approved these changes
Apr 22, 2026
Member
jimboid
left a comment
There was a problem hiding this comment.
An important bug fix. This looks like the origin was the quirky behaviour of how frames from MDA are dealt with in some types of iterables. We've had a valuable report from @ioanaapapa that the numbers are now indeed functioning correctly as per previous behaviour. I'm wholly satisfied that this PR fixes the issue reported with invalid eigen values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolving Issue #317 by correcting the looping over frames.
Changes
Fixing level_dag.py
Tests
Impact