Skip to content

[FIX] Restore free_sub_track scope and keep blockaddition cleanup #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shiv0087 wants to merge 3 commits into
base: master
Choose a base branch
from
+19 −0
Open

[FIX] Restore free_sub_track scope and keep blockaddition cleanup #2270

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc42bf6
fix: correct indentation in blockaddition cleanup
Shiv0087 Mar 31, 2026
dd7d640
fix: restore free_sub_track loop scope and tab indentation
ShivrajsinhJadeja Apr 22, 2026
a73237a
fix: store and free blockaddition message buffer
Shiv0087 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/lib_ccx/matroska.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1898,14 +1898,29 @@ void free_sub_track(struct matroska_sub_track *track)
free(track->lang_ietf);
if (track->codec_id_string != NULL)
free(track->codec_id_string);

for (int i = 0; i < track->sentence_count; i++)
{
struct matroska_sub_sentence *sentence = track->sentences[i];

free(sentence->text);

if (sentence->blockaddition != NULL)
{
/* cue_settings_list is the base of the message buffer;
* cue_identifier and comment are pointers into it */
if (sentence->blockaddition->cue_settings_list != NULL)
free(sentence->blockaddition->cue_settings_list);

Comment on lines +1911 to +1917
free(sentence->blockaddition);
}

free(sentence);
}

if (track->sentences != NULL)
free(track->sentences);

free(track);
}

Expand Down
Loading