fix(sdk-lib-mpc, sdk-core): bind DSG session blobs to their round#8444
Draft
mohammadalfaiyazbitgo wants to merge 1 commit intomasterfrom
Draft
fix(sdk-lib-mpc, sdk-core): bind DSG session blobs to their round#8444mohammadalfaiyazbitgo wants to merge 1 commit intomasterfrom
mohammadalfaiyazbitgo wants to merge 1 commit intomasterfrom
Conversation
Add an optional `expectedRound` parameter to `Dsg.setSession()` that validates the decoded CBOR round against the caller's expectation. Include a round-specific adata suffix in each encrypted offline session blob so that `validateAdata` rejects a blob encrypted for a different round, even if the passphrase is known. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional
expectedRoundparameter toDsg.setSession()that validates the decoded CBOR round against the caller's expectation.Include a round-specific adata suffix in each encrypted offline session blob so that
validateAdatarejects a blob encrypted for a different round, even if the passphrase is known.