AP-416: Use berkeleyEduAlternateID in CAS callback#13
Merged
danschmidt5189 merged 1 commit intomainfrom Aug 20, 2025
Merged
Conversation
da6e4fd to
79f39c9
Compare
Transitions user initialization from the CAS callback flow to the new `berkeleyEduAlternateID` attribute, away from the deprecated `berkeleyEduOfficialEmail`.
79f39c9 to
a2ccfe0
Compare
Contributor
|
Tested locally, looks good!
( Is it meant to redirect to "http://localhost:4000"? ) |
Member
Author
|
@yzhoubk I disabled the galc-ui dev instance running on |
Contributor
|
@danschmidt5189 Just re-pulled and rebuilt, and I see the redirect to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates user initialization code in the CAS callback to use the new
berkeleyEduAlternateIDinstead of the deprecatedberkeleyEduOfficialEmail. This is a one-liner change in the actual codebase, but with a few more references in the tests.Note that I opted to completely remove references to berkeleyEduOfficialEmail, because 1) although CalNet is currently sending both, they will eventually remove it, and 2) this should minimize confusion down the road, in case a developer wonders why we reference both but only use one.
Additionally, I found it hard to test because the SERVE_TEST_UI flag / feature was broken. I've updated index.html to make that work (pinned to galc-ui@snapshot). I recognize that's not directly related to this change, however, so I'm happy to remove it.