Skip to content

AP-416: Use berkeleyEduAlternateID in CAS callback#13

Merged
danschmidt5189 merged 1 commit intomainfrom
AP-416-berkeleyEduOfficialEmail_deprecation
Aug 20, 2025
Merged

AP-416: Use berkeleyEduAlternateID in CAS callback#13
danschmidt5189 merged 1 commit intomainfrom
AP-416-berkeleyEduOfficialEmail_deprecation

Conversation

@danschmidt5189
Copy link
Copy Markdown
Member

@danschmidt5189 danschmidt5189 commented Aug 20, 2025

Updates user initialization code in the CAS callback to use the new berkeleyEduAlternateID instead of the deprecated berkeleyEduOfficialEmail. This is a one-liner change in the actual codebase, but with a few more references in the tests.

Note that I opted to completely remove references to berkeleyEduOfficialEmail, because 1) although CalNet is currently sending both, they will eventually remove it, and 2) this should minimize confusion down the road, in case a developer wonders why we reference both but only use one.

Additionally, I found it hard to test because the SERVE_TEST_UI flag / feature was broken. I've updated index.html to make that work (pinned to galc-ui@snapshot). I recognize that's not directly related to this change, however, so I'm happy to remove it.

@danschmidt5189 danschmidt5189 force-pushed the AP-416-berkeleyEduOfficialEmail_deprecation branch from da6e4fd to 79f39c9 Compare August 20, 2025 17:57
@danschmidt5189 danschmidt5189 marked this pull request as ready for review August 20, 2025 17:59
@danschmidt5189 danschmidt5189 self-assigned this Aug 20, 2025
@danschmidt5189 danschmidt5189 changed the title Ap 416 berkeley edu official email deprecation AP-416: Use berkeleyEduAlternateID in CAS callback Aug 20, 2025
Transitions user initialization from the CAS callback flow to the new `berkeleyEduAlternateID` attribute, away from the deprecated `berkeleyEduOfficialEmail`.
@danschmidt5189 danschmidt5189 force-pushed the AP-416-berkeleyEduOfficialEmail_deprecation branch from 79f39c9 to a2ccfe0 Compare August 20, 2025 18:12
@yzhoubk
Copy link
Copy Markdown
Contributor

yzhoubk commented Aug 20, 2025

Tested locally, looks good!

  1. Index page shows up at "http://localhost:3000"
  2. Calnet login works for making print reserversion, and it redirects to GALC UI: "http://localhost:4000"

( Is it meant to redirect to "http://localhost:4000"? )

@danschmidt5189
Copy link
Copy Markdown
Member Author

@yzhoubk I disabled the galc-ui dev instance running on :4000, rebuilt galc-api, and started everything back up. After doing that I'm not able to reproduce what you saw — I get redirected back to localhost:3000 as expected. Would you double-check? And if you're still seeing that behavior perhaps we could pair.

@yzhoubk
Copy link
Copy Markdown
Contributor

yzhoubk commented Aug 20, 2025

@danschmidt5189 Just re-pulled and rebuilt, and I see the redirect to localhost:3000 on my local too.

@danschmidt5189 danschmidt5189 merged commit 85e1e56 into main Aug 20, 2025
8 checks passed
@anarchivist anarchivist deleted the AP-416-berkeleyEduOfficialEmail_deprecation branch September 17, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants