This repository was archived by the owner on Mar 20, 2024. It is now read-only.
Fixes #266: Stop sessions if exception thrown when resetting#267
Open
dsnopek wants to merge 1 commit intoBehat:masterfrom
Open
Fixes #266: Stop sessions if exception thrown when resetting#267dsnopek wants to merge 1 commit intoBehat:masterfrom
dsnopek wants to merge 1 commit intoBehat:masterfrom
Conversation
Member
|
I'm wondering whether we should handle it in Mink itself. What do you think @aik099 ? |
Member
|
btw, this could allow stopping only the session which was broken, instead of stopping all sessions, in case you have several ones |
aik099
reviewed
Jan 18, 2017
| try { | ||
| $this->mink->resetSessions(); | ||
| } | ||
| catch (\Exception $e) { |
There was a problem hiding this comment.
It's better to handle DriverException or similar Mink exception class. If I'm not mistaken then it would be possible to get actual failed session out of it and stop exactly it.
@stof , something like session self-restart on failed stop? Like new parameter of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for #266 that works in my testing with a sporadic (but pretty reliable) Chrome crash