Skip to content

[WIP] unpin propka to 3.1+ #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IAlibay wants to merge 5 commits into
base: main
Choose a base branch
from
+3 −3
Open

[WIP] unpin propka to 3.1+ #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f29244
let's try unpinning and see what happens
IAlibay Dec 24, 2023
1293654
change variable name for 3.2+ support
IAlibay Dec 24, 2023
90f8ecf
pin to 3.2 for now
IAlibay Dec 24, 2023
57873e6
Merge branch 'main' into unpin-propka
orbeckst May 2, 2024
e7d7f3b
Merge branch 'main' into unpin-propka
orbeckst Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devtools/environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ dependencies:
- codecov
- pip
- pip:
- propka==3.1
- propka==3.2
2 changes: 1 addition & 1 deletion propkatraj/propkatraj.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def _single_frame(self):
# extract pka estimates from each residue
self._pkas.append([g.pka_value for g in groups])
if self._columns is None:
self._columns = [g.atom.resNumb for g in groups]
self._columns = [g.atom.res_num for g in groups]
finally:
# deallocate stream
pstream.close(force=True)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ dependencies = [
"MDAnalysis>=2.1.0",
"numpy",
"pandas",
"propka==3.1",
"propka>=3.2",
]
keywords = [
"molecular simulations",
Expand Down