BATS infra refactor#2031
Merged
gaelicWizard merged 23 commits intoBash-it:masterfrom Mar 4, 2022
Merged
Conversation
gaelicWizard
force-pushed
the
bats-cleanup
branch
5 times, most recently
from
7c897ff to
df2362f
Compare
gaelicWizard
force-pushed
the
bats-cleanup
branch
2 times, most recently
from
b86c32a to
0b03ee2
Compare
gaelicWizard
force-pushed
the
bats-cleanup
branch
21 times, most recently
from
3e58a5f to
86af804
Compare
gaelicWizard
force-pushed
the
bats-cleanup
branch
2 times, most recently
from
30b9782 to
c44d2d5
Compare
NoahGorny
requested changes
Mar 3, 2022
Member
NoahGorny
left a comment
NoahGorny
left a comment
There was a problem hiding this comment.
Hi @gaelicWizard, great changes!
Can you please remove the non bats commits from this PR?
I want to merge the bats for now, and then merge the rest
Contributor
Author
|
@NoahGorny, this is built on top of #2061 and there will be conflicts if I separate, but we can deal with that then. I'll separate later today 👍 |
Run the test *files* in parallel, but not the tests *within* the files. This can be reverted after configuration (i.e., `$BASH_IT/enabled` et al) lives *outside* the repo.
test/uninstall: adopt newly revamped `setup()` test/install: `local_setup_file()`
Contributor
Author
|
@NoahGorny, I didn't realize #2061 was already merged! Rebased on master (with no conflicts) and ready to roll 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_helper.bash,git worktreefor a fast, reliable, and predictable test environment,test_make,$HOMEor local$BASH_IT,bats-coreto tagv1.5.0.I believe this closes #1821.
Motivation and Context
This is chapter 2 of my last BATS patch. This time I understand BATS slightly better!
I disabled intra-file parallelization, but this can be reverted as soon as configuration is no longer inside the repo.
This alsö should resolve the drive behind #1753, as the test environment is now separated from the live repository.
How Has This Been Tested?
Lots and lots of running
test/run...Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.