Update xcconfig in the main target only if using cocoapods#263
Merged
Update xcconfig in the main target only if using cocoapods#263
Conversation
Generated by 🚫 Danger Swift against b8bf1a7 |
shehan-bb
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Detects if user is using Cocoapods and, in that case, only set the xcconfig to the main build configurations to not break the Cocoapods' generate xcconfig file.
How can it be tested
The variants' commands should work in a project with or without Cocoapods. It should be tested in samples on both cases.
Task
Checklist:
make validationlocally with success