Skip to content

Update python 3#167

Open
qasema wants to merge 7 commits intomasterfrom
update_python3
Open

Update python 3#167
qasema wants to merge 7 commits intomasterfrom
update_python3

Conversation

@qasema
Copy link
Copy Markdown

@qasema qasema commented Apr 10, 2023

Did:

updating the Python version from 2.7 to 3.7 and above and updating all the related libraries and syntax error

To Test:

  • clone this Repo
  • make sure you have a Python version 3.7 or above installed. To check: run "python --version"
  • Checkout the branch update_python3
  • run 'source setup.sh' and make sure nothing breaks
  • reset the database run 'python reset-db.py'
  • run 'python run.py" and check the application on your browser running.
  • chick all the taps, add and delete chemicals and nothing breaks and see if they are being saved in the database
  • check any syntax errors from Python 2 such as print statements

Copy link
Copy Markdown

@AndersonStettner AndersonStettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a few places of commented out code blocks, why?

setup.sh Outdated

# Create and activate a clean virtual environment.
virtualenv --python=python2.7 venv
virtualenv --python=python3.9 venv
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be using virtualenv anymore you should just be able to use python -m venv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants