CCE Minor Core Functionality (Edit/View/Withdraw/Modify)

[bledsoef]

Issue Description

Fixes #1399

• Once a proposal is submitted, we cannot currently modify its status (edit, view, withdraw or mark as completed). We need to add functionality to the action dropdown that will allow us to do so.

Changes

• Implemented necessary permissions to allow students to view their minor profile and create proposals.
• Updated all input fields in Request Other Engagement and Summer Experience forms to now populate with existing data, if possible.
• Added new routes to minor/routes.py that load the page with proper permissions.
• Updated the statuses for proposals to match that of Course Proposals.
• Once a proposal is approved by an admin, it can no longer be edited by the student who put it in, only by an admin.
• Added functionality to quickly approve or unapprove a proposal at any stage.

Testing

• Reset database.
• Go to the Minor Management page in the Admin dropdown.
• Select any student's name and go to the Manage Proposals tab.
• Create a new Other Engagement and Summer Experience.
• Mess around with editing data, saving, and making sure it is populated when you go to edit or view it again.
• Run the tests and ensure they work.

While testing, look out for a few things:

• Is the PR functional? Are there any bugs?
• Is page navigation intuitive? Are the required things for creating a proposal clear for our users?
• Are color conventions and webpage design choices clear and in accordance with how we use colors in the rest of the app?

If the above look good, then the PR can be stepped towards merging.

[ojmakinde]

mid pr i'll be honest (i haven't looked at it)

[Copilot]

Copilot reviewed 6 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (6)

• app/templates/minor/cceMinorProposalManagement.html: Language not supported
• app/templates/minor/companyOrganizationInformation.html: Language not supported
• app/templates/minor/profile.html: Language not supported
• app/templates/minor/requestOtherEngagement.html: Language not supported
• app/templates/minor/summerExperience.html: Language not supported
• app/templates/minor/supervisorInformation.html: Language not supported

Comments suppressed due to low confidence (2)

app/controllers/minor/routes.py:88

• [nitpick] The function name 'createSummerExperienceExperience' is redundant and may be unclear. Consider renaming it to something like 'createSummerExperienceRequest' to better reflect its purpose.

def createSummerExperienceExperience(username):

app/logic/minor.py:42

• [nitpick] The error message in the updateSummerExperience function reads 'Error saving summer experience' which may be misleading in an update operation. Consider revising the message to indicate an update failure.

def updateSummerExperience(proposalID, formData):

[RueHaile]

Steps

1. Create a CCE minor request summer experience on studnet-side/ I picked Collins
2. Go in as an admin and try to approve that cce minor. The admin, both Dr. Heggan and Brian, aren't able to approve, edit it, or mark it as complete. There is a logic issue it?

[bakobagassas]

Related to Rue's latest comment:

I verified: edit, approve, mark as completed all work. You should try to pull and update the branch

[bakobagassas]

We cannot input letters into the hours box, but we don't get an indication saying that it is not working because we need to input a number and not letter. Is that okay?

[ojmakinde]

We cannot input letters into the hours box, but we don't get an indication saying that it is not working because we need to input a number and not letter. Is that okay?

Yeah, it's okay because the text box is intuitive enough that the CELTS users will put numbers in the field, I think

[ojmakinde]

Steps

1. Create a CCE minor request summer experience on studnet-side/ I picked Collins

2. Go in as an admin and try to approve that cce minor. The admin, both Dr. Heggan and Brian, aren't able to approve, edit it, or mark it as complete. There is a logic issue it?

The proposal must be submitted by the student (or any user, like Brian or Scott) before it can be approved.
Also, thank you for this observation: I will change the name from "Proposal Submitted by User" to "Proposal Submitted"

[MImran2002]

I have checked for the changes I have requested and they are delivered.

The changes requested were fixed months ago.

[bakobagassas]

I was thinking that it might be good to have validity tags when I don't input a name and try to submit the proposal. Or perhaps it should be another issue?

[bakobagassas]

When I input a letter at first it does not work, however, after I input a number then delete it to input a letter then it works.

[bakobagassas]

I am not able to save a draft if the name of the supervisor or the name of the company is not there. I wonder though, shouldn't we at least be able to save a draft to come back and continue later?

[ojmakinde]

I am not able to save a draft if the name of the supervisor or the name of the company is not there. I wonder though, shouldn't we at least be able to save a draft to come back and continue later?

All fields need to be entered before a draft can be created

[bakobagassas]

I am not able to save a draft if the name of the supervisor or the name of the company is not there. I wonder though, shouldn't we at least be able to save a draft to come back and continue later?

All fields need to be entered before a draft can be created

All good then!

[github-actions]

View Code Coverage