Add a Rep type function for Generic#908
Merged
quark17 merged 2 commits intoB-Lang-org:mainfrom Apr 18, 2026
Merged
Conversation
quark17
approved these changes
Apr 18, 2026
Collaborator
|
@krame505 Looking at this PR it seems we do permit type functions in matching position, they just have to be treated as a variable, typically catch all instances? Was that an intended change or am I misreading the code? |
Collaborator
|
Never mind. I looked more closely and realized the type functions were only in contexts and determined positions. So there's actually no issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
Reptype function, which IMO makes generics-based typeclass implementations easier to read. The name matches theReptype family used in Haskell'sGHC.Genericslibrary.We should probably also add type functions for some of the port-splitting-related utilities, but I will do that in a future PR to avoid merge conflicts with #849.