[Keyvault] add breaking change attribute for GetAzureKeyVaultSecret and GetAzureKeyVaultKey#29051
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull request overview
This PR adds breaking change notification attributes to two Key Vault cmdlets (Get-AzKeyVaultSecret and Get-AzKeyVaultKey) to inform users that certificate-backed secrets and keys will no longer be returned when listing these resources in a future release (version 16.0.0). This change prepares users for the breaking changes planned in PR #29015.
Changes:
- Added
GenericBreakingChangeWithVersionattribute toGetAzureKeyVaultSecretclass - Added
GenericBreakingChangeWithVersionattribute toGetAzureKeyVaultKeyclass - Added necessary namespace import (
Microsoft.WindowsAzure.Commands.Common.CustomAttributes) to both files
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/KeyVault/KeyVault/Commands/Secret/GetAzureKeyVaultSecret.cs | Added breaking change attribute and namespace import to notify users that certificate-backed secrets will no longer be returned when listing secrets |
| src/KeyVault/KeyVault/Commands/Key/GetAzureKeyVaultKey.cs | Added breaking change attribute and namespace import to notify users that certificate-backed keys will no longer be returned when listing keys |
vidai-msft
left a comment
There was a problem hiding this comment.
Please update the change log.
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
f218b2a to
13b426f
Compare
Description
Breaking notification attributes added for GetAzureKeyVaultSecret and GetAzureKeyVaultKey.
Changes will be implemented in #29015
And relates to #26217.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.