[PS] Migrate SecurityInsights module to autorest v4#28447
[PS] Migrate SecurityInsights module to autorest v4#28447
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the SecurityInsights module from AutoRest v3 to v4, updating API models and cmdlet structure. The migration involves significant changes to parameter types, output types, and method signatures to align with the newer AutoRest framework.
Key Changes
- Type simplification from strongly-typed enums to string parameters for improved flexibility
- Output type namespace updates from versioned API models to unversioned ones
- Addition of new parameter sets and JSON-based input methods for cmdlets
Reviewed Changes
Copilot reviewed 150 out of 151 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tools/StaticAnalysis/Exceptions/Az.SecurityInsights/BreakingChangeIssues.csv |
Documents expected breaking changes from the AutoRest v4 migration |
| Multiple help markdown files | Updated parameter types, output types, and documentation to reflect API changes |
tools/StaticAnalysis/Exceptions/Az.SecurityInsights/BreakingChangeIssues.csv
Show resolved
Hide resolved
src/SecurityInsights/SecurityInsights/help/New-AzSentinelAlertRule.md
Outdated
Show resolved
Hide resolved
src/SecurityInsights/SecurityInsights/help/New-AzSentinelIncidentTeam.md
Outdated
Show resolved
Hide resolved
|
To the author of the pull request, |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 152 out of 153 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/SecurityInsights/SecurityInsights.Autorest/test/Update-AzSentinelOnboardingState.Tests.ps1:24
- Both test cases are marked
-skipand contain only aNotImplementedExceptionplaceholder, so there is currently no automated coverage forUpdate-AzSentinelOnboardingStatedespite the cmdlet being introduced/updated in this PR.
Suggested fix: replace these placeholders with real tests (record/playback or mocking) that execute the cmdlet for the supported parameter sets, and remove -skip once they pass reliably.
| [Microsoft.Azure.PowerShell.Cmdlets.SecurityInsights.PSArgumentCompleterAttribute("Activity","Expansion")] | ||
| [Microsoft.Azure.PowerShell.Cmdlets.SecurityInsights.Category('Body')] |
Description
Preannouncement PR:
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.