-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[PS] Migrate ManagedServices module to autorest v4 #27929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoyerJin
wants to merge
5
commits into
main
Choose a base branch
from
joyer/managedservice-migrate-v4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ce2e1b7
Migrate ManagedServices module to autorest v4
JoyerJin 37eb0ba
Create BreakingChangeIssues.csv
JoyerJin 8f20cf8
Merge branch 'main' into joyer/managedservice-migrate-v4
JoyerJin 656cc7c
Merge branch 'main' into joyer/managedservice-migrate-v4
JoyerJin 2b22440
rebuild with Autorest 4.0.752
JunKai-v File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
...rvices.Autorest/custom/autogen-model-cmdlets/New-AzManagedServicesAuthorizationObject.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
|
|
||
| # ---------------------------------------------------------------------------------- | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # Code generated by Microsoft (R) AutoRest Code Generator.Changes may cause incorrect behavior and will be lost if the code | ||
| # is regenerated. | ||
| # ---------------------------------------------------------------------------------- | ||
|
|
||
| <# | ||
| .Synopsis | ||
| Create an in-memory object for Authorization. | ||
| .Description | ||
| Create an in-memory object for Authorization. | ||
|
|
||
| .Outputs | ||
| Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Authorization | ||
| .Link | ||
| https://learn.microsoft.com/powershell/module/Az.ManagedServices/new-azmanagedservicesauthorizationobject | ||
| #> | ||
| function New-AzManagedServicesAuthorizationObject { | ||
| [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.ModelCmdletAttribute()] | ||
| [OutputType('Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Authorization')] | ||
| [CmdletBinding(PositionalBinding=$false)] | ||
| Param( | ||
|
|
||
| [Parameter(HelpMessage="The delegatedRoleDefinitionIds field is required when the roleDefinitionId refers to the User Access Administrator Role. It is the list of role definition ids which define all the permissions that the user in the authorization can assign to other principals.")] | ||
| [string[]] | ||
| $DelegatedRoleDefinitionId, | ||
| [Parameter(Mandatory, HelpMessage="The identifier of the Azure Active Directory principal.")] | ||
| [string] | ||
| $PrincipalId, | ||
| [Parameter(HelpMessage="The display name of the Azure Active Directory principal.")] | ||
| [string] | ||
| $PrincipalIdDisplayName, | ||
| [Parameter(Mandatory, HelpMessage="The identifier of the Azure built-in role that defines the permissions that the Azure Active Directory principal will have on the projected scope.")] | ||
| [string] | ||
| $RoleDefinitionId | ||
| ) | ||
|
|
||
| process { | ||
| $Object = [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Authorization]::New() | ||
|
|
||
| if ($PSBoundParameters.ContainsKey('DelegatedRoleDefinitionId')) { | ||
| $Object.DelegatedRoleDefinitionId = $DelegatedRoleDefinitionId | ||
| } | ||
| if ($PSBoundParameters.ContainsKey('PrincipalId')) { | ||
| $Object.PrincipalId = $PrincipalId | ||
| } | ||
| if ($PSBoundParameters.ContainsKey('PrincipalIdDisplayName')) { | ||
| $Object.PrincipalIdDisplayName = $PrincipalIdDisplayName | ||
| } | ||
| if ($PSBoundParameters.ContainsKey('RoleDefinitionId')) { | ||
| $Object.RoleDefinitionId = $RoleDefinitionId | ||
| } | ||
| return $Object | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script defines
New-AzManagedServicesAuthorizationObject, but the repo already has the same function name atsrc/ManagedServices/ManagedServices.Autorest/custom/New-AzManagedServicesAuthorizationObject.ps1. BecauseAz.ManagedServices.custom.psm1dot-sources all*.ps1undercustom/recursively, having both files will lead to non-deterministic function redefinition/overrides at import time. Keep only one implementation (either remove this autogen file or remove/rename the other one), and ensure the module loads a single, authoritative definition.