Change CBOR encoding strategy order to properly detect Jackson 2#136
Open
Change CBOR encoding strategy order to properly detect Jackson 2#136
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the system checks for Jackson 3 before Jackson 2. Because the Jackson 3 modules are included as standard (non-optional) dependencies in the project, the classpath check for Jackson 3 always evaluates to
true.Consequently, the strategy check never fails, and the framework never reaches the condition to verify if the user is actually running Jackson 2. This can result in the wrong encoding strategy being applied for users who rely on Jackson 2.