Fix: No more crashing/skipped changes for certain changes#1714
Merged
Fix: No more crashing/skipped changes for certain changes#1714
Conversation
See: Simperium/node-simperium#91 See: google/diff-match-patch#80 There have been certain cases where consecutive surrogate pairs crash `diff-match-patch` when it's building the _delta string_. This is because the diffing algorithm finds a common prefix up to and including half of the surrogate pair match when three consecutive code points share the same high surrogate. ``` // before - \ud83d\ude4b\ud83d\ue4b // after - \ud83d\ude4b\ud83d\ue4c\ud83d\ude4b // deltas - eq \ud83d\ude4b\ud83d -> add \ude4c -> eq \ud83d \ude4b ``` This crashes when trying to encode the invalid sequence of UTF-16 code units into `URIEncode`, which expects a valid Unicode string. After the fix the delta groups are normalized to prevent this situation and the `node-simperium` library should be able to process those problematic changesets. This patch updates the dependency on the patched version of `node-simperium`.
belcherj
approved these changes
Nov 14, 2019
Contributor
belcherj
left a comment
belcherj
left a comment
There was a problem hiding this comment.
Let's get this merged and test heavily on Develop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: Simperium/node-simperium#91
See: google/diff-match-patch#80
Possibly fixes:
diff_fromDelta()- maybe a length-counting issue in the Python version)Maybe related but likely not:
Other repos:
There have been certain cases where consecutive surrogate pairs crash
diff-match-patchwhen it's building the delta string. This isbecause the diffing algorithm finds a common prefix up to and including
half of the surrogate pair match when three consecutive code points
share the same high surrogate.
This crashes when trying to encode the invalid sequence of UTF-16 code
units into
URIEncode, which expects a valid Unicode string.After the fix the delta groups are normalized to prevent this situation
and the
node-simperiumlibrary should be able to process thoseproblematic changesets.
This patch updates the dependency on the patched version of
node-simperium.Testing
Follow the sequence described in Automattic/simplenote-macos#397
Add a new note☺️ 🖖🏿
Enter the following emojis:
Insert the following emoji in between: 😃
In
developyou should notice an exception in the dev tools showing that the update failed. Your updates will continue to fail for that note until the emoji sequence is removed. If you clear the browser cache or signout/signin the changes, even those you made after the emoji, will disappear.In this branch the update should work as expected. If you clear the browser cache or signout/signin the changes will remain.
Before
After
