Diff Match Patch

[theck13]

Fix

Update the simperium dependency, which includes updating the diff_match_patch class as described in Simperium/simperium-android#215 and ignoring corrupted ghost objects as described in Simperium/simperium-android#216.

Test

The test requires corrupting a note to see if Simplenote Android can handle it. In order to corrupt a note, checkout commit 9361b81 in the simplenote-ios repository to use for the Simplenote iOS steps below. The steps for Simplenote Web can be performed at https://app.simplenote.com.

1. Android: Open app.
2. iOS: Open app.
3. Web: Open app.
4. iOS: Tap New note action in top app bar.
5. iOS: Insert 🙂🙁 in note.
6. Android: Notice 🙂🙁 in note list.
7. iOS: Insert 😱 between 🙂 and 🙁 in note.
8. iOS: Notice app crashes.
9. Android: Notice 🙂🐨null)� in note list.
10. Web: Notice 🙂�(null)� in note list.
11. Web: Open 🙂�(null)� note.
12. Web: Add "test" to end of 🙂�(null)� note.
13. Android: Open 🙂🐨null)� note.
14. Android: Notice 🙂(null)🙁test in note.

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

Note

@loremattei, these changes will require a new release candidate build once they are merged.

[peril-automattic]

You can test the changes on this Pull Request by downloading the APK here.

[dmsnell]

In testing I confirmed our expected behaviors. The remaining issues with the malformed content disappeared after the first update and thankfully should be rare anyway, coming only from the old corrupted iOS version.