Skip to content

utsnames: replace strcpy to strncpy for premature attention and safety #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GermanAizek wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

utsnames: replace strcpy to strncpy for premature attention and safety #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion utsnames.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ getutsname(struct tstat *curtask)
if ( (offset = strlen(tmphost) - UTSLEN) < 0)
offset = 0;

strcpy(curtask->gen.utsname, tmphost+offset); // copy last part when overflow
// copy last part when overflow
strncpy(curtask->gen.utsname, tmphost+offset, sizeof(curtask->gen.utsname) - 1);
curtask->gen.utsname[sizeof(curtask->gen.utsname) - 1] = '\0';

if (! droprootprivs())
mcleanstop(42, "failed to drop root privs\n");
Expand Down