-
Notifications
You must be signed in to change notification settings - Fork 827
feat(rest-api): add type-aware attribute filter to GET /v1/spans #12524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anticorrelator
wants to merge
17
commits into
main
Choose a base branch
from
dustin/span-attributes-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c8cd236
feat(rest-api): add attribute_filter query parameter to GET /v1/spans…
anticorrelator 5044594
fix(rest-api): address PR #12524 self-review findings
anticorrelator 478d92d
style: fix ruff import sorting in test_spans.py
anticorrelator b350fb7
feat(rest-api): rename attribute_filter → attribute and add type-awar…
anticorrelator c3e9fc0
fix(rest-api): correct TS version gate, remove dead constant, add str…
anticorrelator 30c0be6
fix(rest-api): fix lint, pyright, and stale OpenAPI schema
anticorrelator 363a17b
fix(rest-api): use direct JSON comparison for type-aware attribute fi…
anticorrelator 14b21fc
fix(rest-api): use JSON text comparison for type-aware attribute filt…
anticorrelator c555997
test(rest-api): pin attribute-filter behavior + enrich OpenAPI descri…
anticorrelator 0b53342
test(rest-api): slim span-filter agent-trial harness for external con…
anticorrelator ba0603e
style(rest-api): apply ruff import grouping fixes
anticorrelator fa80fff
chore(client): regenerate phoenix-client openapi types
anticorrelator 64e3c53
fix(client): use attributes maps for span filters
mikeldking 031473f
fix(tests): rename attribute= → attributes= in integration test
anticorrelator 5524941
style(tests): match CI ruff import grouping for test_spans.py
anticorrelator 1852e08
chore(rest-api): remove span-filter agent-trial harness
anticorrelator fcd72bb
fix(client): bump attribute filter min server version to 14.9.0
anticorrelator File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.