Skip to content

Fix #51 segfault #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
probonopd merged 3 commits into from
Aug 5, 2024
Merged

Fix #51 segfault #53

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cdf424
Try to fix #51
probonopd Aug 5, 2024
e6cddd4
Revert recent changes
probonopd Aug 5, 2024
39bfcff
Try to fix build_mount_point
probonopd Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/runtime/runtime.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ extern int sqfs_opt_proc(void* data, const char* arg, int key, struct fuse_args*
#include <fnmatch.h>
#include <sys/mman.h>
#include <stdint.h>
#include <libgen.h>

typedef struct {
uint32_t lo;
Expand Down Expand Up @@ -865,10 +864,8 @@ bool rm_recursive(const char* const path) {
void build_mount_point(char* mount_dir, const char* const argv0, char const* const temp_base, const size_t templen) {
const size_t maxnamelen = 6;

// need to copy argv0 as it's a const value, basename intends to modify it
char* argv0_copy = strdup(argv0);
char* path_basename = basename(argv0_copy);
free(argv0_copy);
char* path_basename;
path_basename = basename(argv0);

size_t namelen = strlen(path_basename);
// limit length of tempdir name
Expand Down