Skip to content

[QC-1343] [TOF] Fix crashing when updating plots #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njacazio merged 3 commits into from
Mar 18, 2026
Merged

[QC-1343] [TOF] Fix crashing when updating plots #2652

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3c5c5b
Fix for crash when updating plot
ercolessi Mar 18, 2026
2a3c2d8
fix
ercolessi Mar 18, 2026
313e696
remove comment
ercolessi Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Modules/TOF/src/TrendingCalibDiagnostics.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,8 @@ void TrendingCalibDiagnostics::generatePlots()
if (auto title = dynamic_cast<TPaveText*>(c->GetPrimitive("title"))) {
title->SetBBoxCenterX(c->GetBBoxCenter().fX);
// It will have an effect only after invoking Draw again.
Copy link
Collaborator

@knopers8 knopers8 Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment above might cause some confusion ;)

Copy link
Collaborator Author

@ercolessi ercolessi Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you indeed :) removed

title->Draw();
c->Modified();
c->Update();
} else {
ILOG(Error, Devel) << "Could not get the title TPaveText of the plot '" << plot.name << "'." << ENDM;
}
Expand Down
3 changes: 2 additions & 1 deletion Modules/TOF/src/TrendingCalibLHCphase.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,8 @@ void TrendingCalibLHCphase::generatePlots()
if (auto title = dynamic_cast<TPaveText*>(c->GetPrimitive("title"))) {
title->SetBBoxCenterX(c->GetBBoxCenter().fX);
// It will have an effect only after invoking Draw again.
title->Draw();
c->Modified();
c->Update();
} else {
ILOG(Error, Devel) << "Could not get the title TPaveText of the plot '" << plot.name << "'." << ENDM;
}
Expand Down
Loading