fix: Detection of HW caps and Num Cpus for FreeBSD(R) and OpenBSD(R)#1269
Open
Martinfx wants to merge 1 commit intoARM-software:mainfrom
Open
fix: Detection of HW caps and Num Cpus for FreeBSD(R) and OpenBSD(R)#1269Martinfx wants to merge 1 commit intoARM-software:mainfrom
Martinfx wants to merge 1 commit intoARM-software:mainfrom
Conversation
Contributor
|
Hi @Martinfx , Can you sign-off your commit please. We forgot it in the last PR unfortunately. |
Contributor
|
@Martinfx I also suggest the following commit and pull request title: fix: Detection of HW caps and Num Cpus for FreeBSD(R) and OpenBSD(R) |
Signed-off-by: Martin Filla <freebsd@sysctl.cz>
Martinfx
force-pushed
the
max-freeebsd-fix-ncpu
branch
from
d90184d to
97df729
Compare
Martinfx
changed the title
Contributor
Author
ok. no problem. |
Contributor
|
@Martinfx |
gunes-arm
requested changes
Mar 16, 2026
| int ncpus = get_hw_capability("hw.ncpu"); | ||
| CpuIsaInfo isainfo; | ||
| std::vector<CpuModel> cpus_model(ncpus); | ||
| isainfo.neon = get_hw_capability("hw.optional.neon"); |
Contributor
There was a problem hiding this comment.
Does this work in FreeBSD? I know it doesn't work for OpenBSD.
#1223 (comment)
says you can use elf_aux_info to detect the HWCAPS.
Contributor
Author
There was a problem hiding this comment.
I will work for better implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.