FIX: Wind rose bins were not properly covering the entire compass.#1001
Open
rcjackson wants to merge 3 commits intoARM-DOE:mainfrom
Open
FIX: Wind rose bins were not properly covering the entire compass.#1001rcjackson wants to merge 3 commits intoARM-DOE:mainfrom
rcjackson wants to merge 3 commits intoARM-DOE:mainfrom
Conversation
zssherman
approved these changes
Apr 20, 2026
Collaborator
zssherman
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the changes! The tests are failing due to noaapsl being down so ill rerun the tests soon.
Collaborator
|
@rcjackson Can you update the test file when you get a chance? |
Collaborator
|
@rcjackson test_plot.png has a windrose in it as well |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A co-author on my WaggleDop paper noticed an issue with a missing bin in the WindRoseDisplay plots. It looks like the bins are not being set up correctly in the WindRoseDisplay object, as they are laid out in a way that would exclude the last division inside the wind rose. See here as an example of the current implementation:

When I put in these new bin centers, there is now a complete histogram throughout the entire compass:
