Skip to content

Enable Indexer cache for DS v3.2 decoding#3529

Open
RissyRan wants to merge 1 commit intomainfrom
dsv32_decode_clean
Open

Enable Indexer cache for DS v3.2 decoding#3529
RissyRan wants to merge 1 commit intomainfrom
dsv32_decode_clean

Conversation

@RissyRan
Copy link
Copy Markdown
Collaborator

@RissyRan RissyRan commented Mar 31, 2026

Description

This is a clean version of previous PR after rebase.

Enable Indexer cache for DS v3.2 decoding, to unblock the eval benchmark for DS v3.2 model with sparse attention bringup.

  • DS reference implementation for Indexer is here
  • Add init_indexer_cache & update_indexer_cache for indexer cache
  • Add encoding_dsv32.py from HF files to enable specific encoding for V3.2
  • Other small changes for benchmark time out setting

Tests

  • All runners are green
  • Training end-to-end (no impact) with a smaller model version: link
  • Test against reference implementation still green: link
  • Decoding gives reasonable
    • small seq len to skip the indexer: link
    • large seq len to process the indexer max_prefill_predict_length=3072 max_target_length=4096: link
  • Reasonable MMLU pro valuation in b/469547559, and sanity check on decoding - link

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@RissyRan RissyRan force-pushed the dsv32_decode_clean branch from d0609de to 024c567 Compare March 31, 2026 20:08
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/layers/attention_mla.py 93.75% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Copy Markdown

🤖 Hi @RissyRan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@github-actions
Copy link
Copy Markdown

🤖 I'm sorry @RissyRan, but I was unable to process your request. Please see the logs for more details.

@RissyRan RissyRan force-pushed the dsv32_decode_clean branch 2 times, most recently from b6120e0 to 1a3b8af Compare March 31, 2026 23:42
@RissyRan RissyRan force-pushed the dsv32_decode_clean branch from 1a3b8af to 646ac9c Compare April 1, 2026 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants