Open
Conversation
PiperOrigin-RevId: 889523297
copybara-service
bot
requested review from
A9isha,
NicoGrande,
NuojCheng,
Obliviour,
RissyRan,
SujeethJinesh,
SurbhiJainUSC,
aireenmei,
bvandermoon,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jacoguzo,
jesselu-google,
jiangjy1982,
khatwanimohit,
mitalisi,
notabee,
parambole,
richjames0,
shauryagup,
shralex,
shuningjin,
suexu1025 and
vipannalla
as code owners
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen below:
https://source.corp.google.com/piper///depot/google3/third_party/py/maxtext/src/maxtext/utils/vocabulary_tiling.py;l=120
the config.num_vocab_tiling is actually being used to tile batch sequence dimension in vocab_tiling_linen_loss. In the subsequent cl/886387786 we are actually adding a way to tile both batch sequence and vocabulary dimension. Therefore, moving forward we need to be able to use num_vocab_tiling to actually tile the vocabulary dimension.