Draft
Conversation
…oming to do something in this god's forsaken addon
- Done using a very naive approach that consumes a lot of resources for no reason - Still delegates some calculations to the server to do them - Some things broken, such as single sound entities - Fallback to single sound is broken - I hate the state of this, rewrite coming soon enough! WIP
… have engine registration to work with the sound table
…its engine registration thing
- Move sound counting to its own local function - Throttle is now networked properly - Fix DoPitchVolumeAtRPM function to use pitch and width properly - Some other changes to documentation
…dd some safeguards to sound creation
…, labels still not updating
…ing correctly, added a sound path validation icon
…und creation, include the volume on pitchvolume mixing instead of just fallback
… instances, set idle NumWang minimum to 0
…nd menu, fix regression with engines with no soundbank
…on is not implemented yet
… sound - It can now fully replace the sounds!
… sound - It can now fully replace the sounds!
- Added a button to refresh the graph - Plot line graph color is now randomized - Some minor optimizations to both the graph and soundbank play
…or non existant sound table. Some improvements to the sound replacer menu * Switched Pitch for Volume Y label to avoid confusion * Removed two unimplemented submenu choices temporarily * Added contact group for the sound replacer menu, warn that this is a WIP panel * Improved the graph panel by allowing a higher fidelity
…miscellaneous tweaks
…r validation to avoid having it potentially leak in memory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨WIP: Overhauls the sound replacer menu to allow some entities to play multiple, interpolated sounds. 🚨WIP
This changes the way how sounds are played, by allowing multiple sounds to play from a single entity.
For engines this means:
For guns this means:
I have created a draft for this so others can look and possibly guide me on this, better ways to approach any problems that will arise, etc.
Ideally i would go on and allow web sounds to be played, since this relies on the client having the sounds at disposition to be played in their respective machines, which is possible some other clients may not have.